chore: misc clang-tidy fixes #23648
Merged
chore: misc clang-tidy fixes #23648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Noah Watkins <[email protected]>
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1278/execroot/_main/src/v/security/audit/schemas/types.h:163:31: error: unused function 'ocsf_redpanda_metadata' [clang-diagnostic-unused-function]
163 | static inline const metadata& ocsf_redpanda_metadata() {
| ^~~~~~~~~~~~~~~~~~~~~~
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1278/execroot/_main/src/v/security/audit/schemas/types.h:172:31: error: unused function 'ocsf_redpanda_metadata_cloud_profile' [clang-diagnostic-unused-function]
172 | static inline const metadata& ocsf_redpanda_metadata_cloud_profile() {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Noah Watkins <[email protected]>
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1435/execroot/_main/src/v/wasm/wasi.h:65:28: error: unused variable 'preview_1_start_function_name' [clang-diagnostic-unused-const-variable]
65 | constexpr std::string_view preview_1_start_function_name = "_start";
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1435/execroot/_main/src/v/wasm/wasi.h:69:19: error: unused variable 'ERRNO_SUCCESS' [clang-diagnostic-unused-const-variable]
69 | constexpr errno_t ERRNO_SUCCESS{0};
| ^~~~~~~~~~~~~
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1435/execroot/_main/src/v/wasm/wasi.h:70:19: error: unused variable 'ERRNO_INVAL' [clang-diagnostic-unused-const-variable]
70 | constexpr errno_t ERRNO_INVAL{16};
| ^~~~~~~~~~~
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1435/execroot/_main/src/v/wasm/wasi.h:71:19: error: unused variable 'ERRNO_NOSYS' [clang-diagnostic-unused-const-variable]
71 | constexpr errno_t ERRNO_NOSYS{52};
| ^~~~~~~~~~~
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1435/execroot/_main/src/v/wasm/wasi.h:72:19: error: unused variable 'ERRNO_BADF' [clang-diagnostic-unused-const-variable]
72 | constexpr errno_t ERRNO_BADF{8};
| ^~~~~~~~~~
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1435/execroot/_main/src/v/wasm/wasi.h:76:22: error: unused variable 'REALTIME_CLOCK_ID' [clang-diagnostic-unused-const-variable]
76 | constexpr clock_id_t REALTIME_CLOCK_ID{0};
| ^~~~~~~~~~~~~~~~~
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1435/execroot/_main/src/v/wasm/wasi.h:77:22: error: unused variable 'MONOTONIC_CLOCK_ID' [clang-diagnostic-unused-const-variable]
77 | constexpr clock_id_t MONOTONIC_CLOCK_ID{1};
| ^~~~~~~~~~~~~~~~~~
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1435/execroot/_main/src/v/wasm/wasi.h:78:22: error: unused variable 'PROCESS_CPUTIME_CLOCK_ID' [clang-diagnostic-unused-const-variable]
78 | constexpr clock_id_t PROCESS_CPUTIME_CLOCK_ID{2};
| ^~~~~~~~~~~~~~~~~~~~~~~~
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1435/execroot/_main/src/v/wasm/wasi.h:79:22: error: unused variable 'THREAD_CPUTIME_CLOCK_ID' [clang-diagnostic-unused-const-variable]
79 | constexpr clock_id_t THREAD_CPUTIME_CLOCK_ID{3};
| ^~~~~~~~~~~~~~~~~~~~~~~
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1435/execroot/_main/src/v/wasm/wasi.h:92:24: error: unused variable 'CLOCK_EVENT_TYPE' [clang-diagnostic-unused-const-variable]
92 | constexpr event_type_t CLOCK_EVENT_TYPE{0};
| ^~~~~~~~~~~~~~~~
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1435/execroot/_main/src/v/wasm/wasi.h:97:24: error: unused variable 'FD_READ_EVENT_TYPE' [clang-diagnostic-unused-const-variable]
97 | constexpr event_type_t FD_READ_EVENT_TYPE{1};
| ^~~~~~~~~~~~~~~~~~
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1435/execroot/_main/src/v/wasm/wasi.h:102:24: error: unused variable 'FD_WRITE_EVENT_TYPE' [clang-diagnostic-unused-const-variable]
102 | constexpr event_type_t FD_WRITE_EVENT_TYPE{2};
| ^~~~~~~~~~~~~~~~~~~
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1435/execroot/_main/src/v/wasm/wasi.h:116:27: error: unused variable 'RELATIVE_TIME_SUBCLOCK_FLAG' [clang-diagnostic-unused-const-variable]
116 | constexpr subclockflags_t RELATIVE_TIME_SUBCLOCK_FLAG{0};
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1435/execroot/_main/src/v/wasm/wasi.h:117:27: error: unused variable 'ABSOLUTE_TIME_SUBCLOCK_FLAG' [clang-diagnostic-unused-const-variable]
117 | constexpr subclockflags_t ABSOLUTE_TIME_SUBCLOCK_FLAG{1};
Signed-off-by: Noah Watkins <[email protected]>
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1219/execroot/_main/src/v/wasm/wasmtime.cc:181:8: error: unmatched 'NOLINTBEGIN' comment without a subsequent 'NOLINTEND' comment [clang-tidy-nolint] 181 | // NOLINTBEGIN(bugprone-easily-swappable-parameters) Signed-off-by: Noah Watkins <[email protected]>
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1752/execroot/_main/src/v/cloud_storage_clients/client_pool.h:36:24: error: unused variable 'self_config_shard' [clang-diagnostic-unused-const-variable]
36 | constexpr ss::shard_id self_config_shard = ss::shard_id{0};
| ^~~~~~~~~~~~~~~~~
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/2577/execroot/_main/src/v/cloud_storage/recursive_directory_walker.h:23:16: error: unused variable 'cache_tmp_file_extension' [clang-diagnostic-unused-const-variable]
23 | constexpr auto cache_tmp_file_extension{".part"};
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/8954/execroot/_main/src/v/cloud_storage/tests/common_def.h:36:19: error: unused variable 'archiver_term' [clang-diagnostic-unused-const-variable]
36 | static const auto archiver_term = model::term_id{123};
| ^~~~~~~~~~~~~
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/9899/execroot/_main/src/v/cloud_storage/cache_service.h:43:41: error: unused variable 'cache_hydration_timeout' [clang-diagnostic-unused-const-variable]
43 | static const ss::lowres_clock::duration cache_hydration_timeout = 60s;
| ^~~~~~~~~~~~~~~~~~~~~~~
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/9899/execroot/_main/src/v/cloud_storage/cache_service.h:44:41: error: unused variable 'cache_hydration_backoff' [clang-diagnostic-unused-const-variable]
44 | static const ss::lowres_clock::duration cache_hydration_backoff = 250ms;
| ^~~~~~~~~~~~~~~~~~~~~~~
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/9899/execroot/_main/src/v/cloud_storage/cache_service.h:48:41: error: unused variable 'cache_thrash_backoff' [clang-diagnostic-unused-const-variable]
48 | static const ss::lowres_clock::duration cache_thrash_backoff = 5000ms;
| ^~~~~~~~~~~~~~~~~~~~
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/10015/execroot/_main/src/v/cloud_storage/remote.h:45:31: error: unused variable 'auth_refresh_shard_id' [clang-diagnostic-unused-const-variable]
45 | static constexpr ss::shard_id auth_refresh_shard_id = 0;
| ^~~~~~~~~~~~~~~~~~~~~
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/10185/execroot/_main/src/v/cloud_storage/segment_meta_cstore.h:33:18: error: unused variable 'cstore_sampling_rate' [clang-diagnostic-unused-const-variable]
33 | constexpr size_t cstore_sampling_rate = 8;
| ^~~~~~~~~~~~~~~~~~~~
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/137/execroot/_main/src/v/cloud_storage/remote_segment.h:43:25: error: unused variable 'remote_segment_sampling_step_bytes' [clang-diagnostic-unused-const-variable]
43 | static constexpr size_t remote_segment_sampling_step_bytes = 64_KiB;
Signed-off-by: Noah Watkins <[email protected]>
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1858/execroot/_main/src/v/model/timeout_clock.h:27:42: error: unused variable 'max_duration' [clang-diagnostic-unused-const-variable]
27 | static constexpr timeout_clock::duration max_duration
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/7748/execroot/_main/src/v/model/fundamental.h:96:31: error: unused variable 'default_cluster_uuid' [clang-diagnostic-unused-const-variable]
96 | static constexpr cluster_uuid default_cluster_uuid{};
| ^~~~~~~~~~~~~~~~~~~~
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/7748/execroot/_main/src/v/model/fundamental.h:105:19: error: unused variable 'unassigned_node_id' [clang-diagnostic-unused-const-variable]
105 | constexpr node_id unassigned_node_id(-1);
| ^~~~~~~~~~~~~~~~~~
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/7748/execroot/_main/src/v/model/fundamental.h:294:32: error: unused variable 'invalid_lso' [clang-diagnostic-unused-const-variable]
294 | static constexpr model::offset invalid_lso{next_offset(model::offset::min())};
| ^~~~~~~~~~~
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/7748/execroot/_main/src/v/model/fundamental.h:429:41: error: unused variable 'current_control_record_version' [clang-diagnostic-unused-const-variable]
429 | static constexpr control_record_version current_control_record_version{0};
Signed-off-by: Noah Watkins <[email protected]>
model: fix unused variable warning
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/8109/execroot/_main/src/v/model/record.h:614:36: error: unused variable 'no_pid' [clang-diagnostic-unused-const-variable]
614 | static constexpr producer_identity no_pid{no_producer_id, no_producer_epoch};
Signed-off-by: Noah Watkins <[email protected]>
Error while processing /home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1987/execroot/_main/src/v/storage/tests/utils/disk_log_builder.h.
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1987/execroot/_main/src/v/storage/tests/utils/disk_log_builder.h:40:26: error: function 'log_builder_config' is not needed and will not be emitted [clang-diagnostic-unneeded-internal-declaration]
40 | static inline log_config log_builder_config() {
| ^~~~~~~~~~~~~~~~~~
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1987/execroot/_main/src/v/storage/tests/utils/disk_log_builder.h:48:33: error: function 'reader_config' is not needed and will not be emitted [clang-diagnostic-unneeded-internal-declaration]
48 | static inline log_reader_config reader_config() {
| ^~~~~~~~~~~~~
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1987/execroot/_main/src/v/storage/tests/utils/disk_log_builder.h:55:33: error: function 'append_config' is not needed and will not be emitted [clang-diagnostic-unneeded-internal-declaration]
55 | static inline log_append_config append_config() {
| ^~~~~~~~~~~~~
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1987/execroot/_main/src/v/storage/tests/utils/disk_log_builder.h:62:26: error: function 'log_builder_ntp' is not needed and will not be emitted [clang-diagnostic-unneeded-internal-declaration]
62 | static inline model::ntp log_builder_ntp() {
| ^~~~~~~~~~~~~~~
Signed-off-by: Noah Watkins <[email protected]>
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/external/toolchains_llvm~~llvm~llvm_18_toolchain_llvm/bin/../include/c++/v1/__type_traits/is_base_of.h:26:59: error: incomplete type 'storage::segment' used in type trait expression [clang-diagnostic-error]
26 | inline constexpr bool is_base_of_v = __is_base_of(_Bp, _Dp);
| ^
external/_main~non_module_dependencies~seastar/include/seastar/core/shared_ptr.hh:241:15: note: in instantiation of variable template specialization 'std::is_base_of_v<seastar::enable_lw_shared_from_this<storage::segment>, storage::segment>' requested here
241 | std::is_base_of_v<enable_lw_shared_from_this<T>, T>,
| ^
external/_main~non_module_dependencies~seastar/include/seastar/core/shared_ptr.hh:324:13: note: in instantiation of template class 'seastar::internal::lw_shared_ptr_accessors<storage::segment>' requested here
324 | accessors<T>::dispose(_p);
| ^
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/external/toolchains_llvm~~llvm~llvm_18_toolchain_llvm/bin/../include/c++/v1/__memory/construct_at.h:67:11: note: in instantiation of member function 'seastar::lw_shared_ptr<storage::segment>::~lw_shared_ptr' requested here
67 | __loc->~_Tp();
| ^
bazel-out/k8-fastbuild/bin/src/v/storage/_virtual_includes/storage/storage/segment_set.h:54:5: note: in instantiation of member function 'seastar::circular_buffer<seastar::lw_shared_ptr<storage::segment>>::~circular_buffer' requested here
54 | segment_set(segment_set&&) noexcept = default;
Signed-off-by: Noah Watkins <[email protected]>
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/2385/execroot/_main/src/v/raft/tests/raft_fixture.h:42:33: error: unused variable 'test_group' [clang-diagnostic-unused-const-variable]
42 | static constexpr raft::group_id test_group(123);
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/9068/execroot/_main/src/v/raft/types.h:727:33: error: unused variable 'zero_voter_priority' [clang-diagnostic-unused-const-variable]
727 | static constexpr voter_priority zero_voter_priority = voter_priority{0};
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/9068/execroot/_main/src/v/raft/types.h:729:33: error: unused variable 'min_voter_priority' [clang-diagnostic-unused-const-variable]
729 | static constexpr voter_priority min_voter_priority = voter_priority{1};
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/9145/execroot/_main/src/v/raft/persisted_stm.h:28:31: error: unused variable 'stm_snapshot_version_v0' [clang-diagnostic-unused-const-variable]
28 | static constexpr const int8_t stm_snapshot_version_v0 = 0;
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/9145/execroot/_main/src/v/raft/persisted_stm.h:29:31: error: unused variable 'stm_snapshot_version' [clang-diagnostic-unused-const-variable]
29 | static constexpr const int8_t stm_snapshot_version = 1;
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/9498/execroot/_main/src/v/raft/group_configuration.h:29:37: error: unused variable 'no_revision' [clang-diagnostic-unused-const-variable]
29 | static constexpr model::revision_id no_revision{};
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/9625/execroot/_main/src/v/raft/notification.h:19:41: error: unused variable 'notification_id_type_invalid' [clang-diagnostic-unused-const-variable]
19 | constexpr group_manager_notification_id notification_id_type_invalid{-1};
Signed-off-by: Noah Watkins <[email protected]>
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/2505/execroot/_main/src/v/kafka/protocol/kafka_batch_adapter.h:25:18: error: unused variable 'kafka_header_size' [clang-diagnostic-unused-const-variable]
25 | constexpr size_t kafka_header_size = sizeof(int64_t) + // base offset
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/8764/execroot/_main/src/v/kafka/protocol/types.h:134:30: error: unused variable 'never_flexible' [clang-diagnostic-unused-const-variable]
134 | static constexpr api_version never_flexible = api_version(-1);
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/281/execroot/_main/src/v/kafka/client/brokers.h:29:22: error: unused variable 'unknown_node_id' [clang-diagnostic-unused-const-variable]
29 | const model::node_id unknown_node_id{-1};
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1735/execroot/_main/src/v/kafka/server/handlers/topics/types.h:40:35: error: unused variable 'topic_property_compaction_strategy' [clang-diagnostic-unused-const-variable]
40 | static constexpr std::string_view topic_property_compaction_strategy
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1735/execroot/_main/src/v/kafka/server/handlers/topics/types.h:42:35: error: unused variable 'topic_property_timestamp_type' [clang-diagnostic-unused-const-variable]
42 | static constexpr std::string_view topic_property_timestamp_type
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1735/execroot/_main/src/v/kafka/server/handlers/topics/types.h:44:35: error: unused variable 'topic_property_segment_size' [clang-diagnostic-unused-const-variable]
44 | static constexpr std::string_view topic_property_segment_size = "segment.bytes";
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1735/execroot/_main/src/v/kafka/server/handlers/topics/types.h:45:35: error: unused variable 'topic_property_max_message_bytes' [clang-diagnostic-unused-const-variable]
45 | static constexpr std::string_view topic_property_max_message_bytes
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1735/execroot/_main/src/v/kafka/server/handlers/topics/types.h:47:35: error: unused variable 'topic_property_recovery' [clang-diagnostic-unused-const-variable]
47 | static constexpr std::string_view topic_property_recovery
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1735/execroot/_main/src/v/kafka/server/handlers/topics/types.h:49:35: error: unused variable 'topic_property_remote_write' [clang-diagnostic-unused-const-variable]
49 | static constexpr std::string_view topic_property_remote_write
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1735/execroot/_main/src/v/kafka/server/handlers/topics/types.h:51:35: error: unused variable 'topic_property_remote_read' [clang-diagnostic-unused-const-variable]
51 | static constexpr std::string_view topic_property_remote_read
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1735/execroot/_main/src/v/kafka/server/handlers/topics/types.h:53:35: error: unused variable 'topic_property_read_replica' [clang-diagnostic-unused-const-variable]
53 | static constexpr std::string_view topic_property_read_replica
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1735/execroot/_main/src/v/kafka/server/handlers/topics/types.h:55:35: error: unused variable 'topic_property_replication_factor' [clang-diagnostic-unused-const-variable]
55 | static constexpr std::string_view topic_property_replication_factor
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1735/execroot/_main/src/v/kafka/server/handlers/topics/types.h:57:35: error: unused variable 'topic_property_remote_delete' [clang-diagnostic-unused-const-variable]
57 | static constexpr std::string_view topic_property_remote_delete
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1735/execroot/_main/src/v/kafka/server/handlers/topics/types.h:59:35: error: unused variable 'topic_property_segment_ms' [clang-diagnostic-unused-const-variable]
59 | static constexpr std::string_view topic_property_segment_ms = "segment.ms";
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1735/execroot/_main/src/v/kafka/server/handlers/topics/types.h:60:35: error: unused variable 'topic_property_write_caching' [clang-diagnostic-unused-const-variable]
60 | static constexpr std::string_view topic_property_write_caching
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1735/execroot/_main/src/v/kafka/server/handlers/topics/types.h:63:35: error: unused variable 'topic_property_flush_ms' [clang-diagnostic-unused-const-variable]
63 | static constexpr std::string_view topic_property_flush_ms = "flush.ms";
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1735/execroot/_main/src/v/kafka/server/handlers/topics/types.h:64:35: error: unused variable 'topic_property_flush_bytes' [clang-diagnostic-unused-const-variable]
64 | static constexpr std::string_view topic_property_flush_bytes = "flush.bytes";
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1735/execroot/_main/src/v/kafka/server/handlers/topics/types.h:67:35: error: unused variable 'topic_property_record_key_schema_id_validation' [clang-diagnostic-unused-const-variable]
67 | static constexpr std::string_view topic_property_record_key_schema_id_validation
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1735/execroot/_main/src/v/kafka/server/handlers/topics/types.h:70:3: error: unused variable 'topic_property_record_key_subject_name_strategy' [clang-diagnostic-unused-const-variable]
70 | topic_property_record_key_subject_name_strategy
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1735/execroot/_main/src/v/kafka/server/handlers/topics/types.h:73:3: error: unused variable 'topic_property_record_value_schema_id_validation' [clang-diagnostic-unused-const-variable]
73 | topic_property_record_value_schema_id_validation
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1735/execroot/_main/src/v/kafka/server/handlers/topics/types.h:76:3: error: unused variable 'topic_property_record_value_subject_name_strategy' [clang-diagnostic-unused-const-variable]
76 | topic_property_record_value_subject_name_strategy
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1735/execroot/_main/src/v/kafka/server/handlers/topics/types.h:81:3: error: unused variable 'topic_property_record_key_schema_id_validation_compat' [clang-diagnostic-unused-const-variable]
81 | topic_property_record_key_schema_id_validation_compat
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/2694/execroot/_main/src/v/kafka/server/handlers/topics/types.h:84:3: error: unused variable 'topic_property_record_key_subject_name_strategy_compat' [clang-diagnostic-unused-const-variable]
84 | topic_property_record_key_subject_name_strategy_compat
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/2694/execroot/_main/src/v/kafka/server/handlers/topics/types.h:87:3: error: unused variable 'topic_property_record_value_schema_id_validation_compat' [clang-diagnostic-unused-const-variable]
87 | topic_property_record_value_schema_id_validation_compat
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/2694/execroot/_main/src/v/kafka/server/handlers/topics/types.h:90:3: error: unused variable 'topic_property_record_value_subject_name_strategy_compat' [clang-diagnostic-unused-const-variable]
90 | topic_property_record_value_subject_name_strategy_compat
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/2694/execroot/_main/src/v/kafka/server/handlers/topics/types.h:93:35: error: unused variable 'topic_property_mpx_virtual_cluster_id' [clang-diagnostic-unused-const-variable]
93 | static constexpr std::string_view topic_property_mpx_virtual_cluster_id
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/2694/execroot/_main/src/v/kafka/server/handlers/topics/types.h:96:35: error: unused variable 'topic_property_iceberg_enabled' [clang-diagnostic-unused-const-variable]
96 | static constexpr std::string_view topic_property_iceberg_enabled
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/2694/execroot/_main/src/v/kafka/server/handlers/topics/types.h:99:35: error: unused variable 'topic_property_leaders_preference' [clang-diagnostic-unused-const-variable]
99 | static constexpr std::string_view topic_property_leaders_preference
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/2694/execroot/_main/src/v/kafka/server/handlers/topics/types.h:104:51: error: unused variable 'allowlist_topic_noop_confs' [clang-diagnostic-unused-const-variable]
104 | static constexpr std::array<std::string_view, 20> allowlist_topic_noop_confs = {
Signed-off-by: Noah Watkins <[email protected]>
kafka: fix unused variable warning
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/3286/execroot/_main/src/v/kafka/server/request_context.h:59:16: error: unused variable 'request_header_size' [clang-diagnostic-unused-const-variable]
59 | constexpr auto request_header_size = sizeof(int16_t) + sizeof(int16_t)
Signed-off-by: Noah Watkins <[email protected]>
needs to be broken out to avoid circular dep Signed-off-by: Noah Watkins <[email protected]>
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/8713/execroot/_main/src/v/debug_bundle/types.h:35:31: error: unused variable 'service_shard' [clang-diagnostic-unused-const-variable]
35 | static constexpr ss::shard_id service_shard = 0;
| ^~~~~~~~~~~~~
Signed-off-by: Noah Watkins <[email protected]>
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/10047/execroot/_main/src/v/cluster/tests/leader_balancer_test_utils.h:20:54: error: unused function 'make_cluster_index' [clang-diagnostic-unused-function]
20 | static cluster::leader_balancer_strategy::index_type make_cluster_index(
| ^~~~~~~~~~~~~~~~~~
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/10047/execroot/_main/src/v/cluster/tests/leader_balancer_test_utils.h:54:61: error: unused function 'copy_cluster_index' [clang-diagnostic-unused-function]
54 | static inline cluster::leader_balancer_strategy::index_type copy_cluster_index(
| ^~~~~~~~~~~~~~~~~~
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/41/execroot/_main/src/v/cluster/tests/leader_balancer_constraints_utils.h:116:13: error: unused function 'group_to_topic_from_spec' [clang-diagnostic-unused-function]
116 | static auto group_to_topic_from_spec(const group_to_ntp_spec& spec) {
| ^~~~~~~~~~~~~~~~~~~~~~~~
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/41/execroot/_main/src/v/cluster/tests/leader_balancer_constraints_utils.h:147:13: error: unused function 'no_movement' [clang-diagnostic-unused-function]
147 | static bool no_movement(
| ^~~~~~~~~~~
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/41/execroot/_main/src/v/cluster/tests/leader_balancer_constraints_utils.h:174:20: error: unused function 'expect_movement' [clang-diagnostic-unused-function]
174 | static ss::sstring expect_movement(
| ^~~~~~~~~~~~~~~
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/41/execroot/_main/src/v/cluster/tests/leader_balancer_constraints_utils.h:211:21: error: unused function 're' [clang-diagnostic-unused-function]
211 | static reassignment re(unsigned group, int from, int to) {
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1475/execroot/_main/src/v/cluster/distributed_kv_stm_types.h:70:1: error: unused function 'make_repartitioning_batch' [clang-diagnostic-unused-function]
70 | make_repartitioning_batch(size_t num_partitions) {
/home/nwatkins/.cache/bazel/_bazel_nwatkins/31f1aa7012681f681e8d49a1818a8564/sandbox/linux-sandbox/1953/execroot/_main/src/v/cluster/archival/types.h:169:22: error: unused variable 'max_reuploads_per_run' [clang-diagnostic-unused-const-variable]
169 | static constexpr int max_reuploads_per_run = 4;
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/55882#019263c1-b8e0-436a-8ca9-60bd196cbdc8 |
dotnwat
requested review from
mmaslankaprv,
WillemKauf,
bharathv,
oleiman,
rockwotj,
andrwng and
StephanDollberg
and removed request for
mmaslankaprv
WillemKauf
approved these changes
Oct 7, 2024
| sizeof(uint32_t) + // crc | ||
| sizeof(int16_t) + // attributes | ||
| sizeof(int32_t) | ||
| + // last offset delta |
There was a problem hiding this comment.
yeh, hah. should have put it in //clang-format disable block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
misc clang-tidy fixes and vegetables
Backports Required
Release Notes