Some oversized alloc high partition count improvements #24578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanDollberg
requested review from
travisdowns,
ballard26 and
mmaslankaprv
Retry command for Build#59797please wait until all jobs are finished before running the slash command |
CI test resultstest results on build#59797
test results on build#59908
test results on build#59952
test results on build#60033
|
travisdowns
reviewed
Dec 17, 2024
travisdowns
reviewed
Dec 18, 2024
src/v/kafka/server/handlers/fetch.h
Outdated
| : fetches_per_shard() { | ||
| fetches_per_shard.reserve(shards); | ||
| for (size_t i = 0; i < shards; i++) { | ||
| auto& fps = fetches_per_shard.emplace_back(start_time); |
There was a problem hiding this comment.
IMO it's better to just change the shard_fetch ctor to take time & shard now, and then you can pass them both to emplace and void this weird thing where we fill in the shard after (should be no slower, may be faster). Then we don't leave shard uninit any more which is good.
I believe it was me who did it like this, mostly just to avail myself of the "n copies" constructor but we aren't using that any more.
There was a problem hiding this comment.
(approving though so feel free to ignore)
travisdowns
previously approved these changes
Dec 18, 2024
|
/ci-repeat 1 |
StephanDollberg
force-pushed
the
stephan/more-oversized-high-part
branch
3 times, most recently
from
721745d to
bd30a74
Compare
travisdowns
previously approved these changes
Dec 18, 2024
StephanDollberg
force-pushed
the
stephan/more-oversized-high-part
branch
from
bd30a74 to
ff22b10
Compare
Retry command for Build#59952please wait until all jobs are finished before running the slash command |
For super high partition topics at high partition density these can lead to oversized allocs due to the use of `absl::flat_hash_map`. Switch to chunked_hash_map.
`ntp_fetch_config` is 250 bytes. When doing super wide reads of 500-1000k partitions (quite niche) this goes above the oversized alloc threshold. Switch to chunked_vector. Switch responses too for uniformity.
travisdowns
force-pushed
the
stephan/more-oversized-high-part
branch
from
ff22b10 to
7c334c3
Compare
|
(rebased to kick off CI again) |
travisdowns
approved these changes
Dec 23, 2024
travisdowns
approved these changes
Dec 23, 2024
mmaslankaprv
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address some oversized alloc in niche cases like super wide reads and super large topics.
Backports Required
Release Notes