Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve before-index performance #223

Open
nathanmarz opened this issue Jul 24, 2017 · 1 comment
Open

Improve before-index performance #223

nathanmarz opened this issue Jul 24, 2017 · 1 comment
Labels
enhancement

Comments

@nathanmarz
Copy link
Collaborator

Currently it just uses srange to do insertion but can be done more efficiently.
@nathanmarz
Copy link
Collaborator Author

Also make a benchmark comparing before-index against srange to show improvement.

jeff303 added a commit to jeff303/specter that referenced this issue Aug 3, 2020
@jeff303
redplanetlabs#223 - Improve before-index performance
5e51ef1 
Adding before-index implementation that uses take/drop instead of setval/srange

Adding new functional test to confirm behavior when operating on a string

Adding benchmark for old versus new implementation of before-index
jeff303 added a commit to jeff303/specter that referenced this issue Sep 16, 2020
@jeff303
Improve before-index performance redplanetlabs#223
307db4d 
Adding new protocol for performing the insert-before-idx operation, with
implementations for core collection types

Adding new functional test to confirm behavior when operating on a string
jeff303 added a commit to jeff303/specter that referenced this issue Sep 16, 2020
@jeff303
Improve before-index performance redplanetlabs#223
6d14f16 
Adding new protocol for performing the insert-before-idx operation, with
implementations for core collection types

Adding new functional test to confirm behavior when operating on a string
jeff303 added a commit to jeff303/specter that referenced this issue Sep 17, 2020
@jeff303
Improve before-index performance redplanetlabs#223
9027f7f 
Adding new protocol for performing the insert-before-idx operation, with
implementations for core collection types

Adding new functional test to confirm behavior when operating on a string

Adding benchmarks to compare new performance vs old implementation, and
also against cons at beginning of list
jeff303 added a commit to jeff303/specter that referenced this issue Sep 17, 2020
@jeff303
Improve before-index performance redplanetlabs#223
072383b 
Adding new protocol for performing the insert-before-idx operation, with
implementations for core collection types

Adding new functional test to confirm behavior when operating on a string

Adding benchmarks to compare new performance vs old implementation vs
core Clojure in a couple of cases
jeff303 added a commit to jeff303/specter that referenced this issue Sep 17, 2020
@jeff303
Improve before-index performance redplanetlabs#223
3fb2985 
Adding new protocol for performing the insert-before-idx operation, with
implementations for core collection types

Adding new functional test to confirm behavior when operating on a string

Adding benchmarks to compare new performance vs old implementation vs
core Clojure in a couple of cases
nathanmarz pushed a commit that referenced this issue Sep 17, 2020
@jeff303
Improve before-index performance #223 (#291)
2e002c1 
Adding new protocol for performing the insert-before-idx operation, with
implementations for core collection types

Adding new functional test to confirm behavior when operating on a string

Adding benchmarks to compare new performance vs old implementation vs
core Clojure in a couple of cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nathanmarz