-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
can't use react-redux with ink #1457
Comments
We do have a sort-of hard dependency on either For other renderers, you'll need to use the |
Closing to track in #1458 |
oh, 'alternate-renderers' looks like what I needed. Thank you! |
@mprast sure! Please let us know if you have any issues using that - I'm not sure how many people have actually used it for real :) But, yeah, that's exactly why we added it. |
Do you want to request a feature or report a bug?
report a bug
(If this is a usage question, please do not post it here—post it on Stack Overflow instead. If this is not a “feature” or a “bug”, or the phrase “How do I...?” applies, then it's probably a usage question.)
What is the current behavior?
I'm trying to use react-redux with ink and yarn v2. When I attempt to import
Provider
I'm met with the following:I'm guessing it's because react-redux is trying to do a static import here:
react-redux/src/index.js
Line 11 in 5e6205a
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Paste the link to a CodeSandbox (https://codesandbox.io/s/new) or RN Snack (https://snack.expo.io/) example below:
demo: https://codesandbox.io/s/festive-leftpad-cjr2w
What is the expected behavior?
I'm expecting to be able to use Redux without react-dom or react-native, since the impression I got from the docs is that react-redux doesn't or shouldn't have hard dependencies on a particular rendering library (if I'm mistaken and didn't miss something obvious it might be a good idea to add a disclaimer to the README!)
For now I can add
react-dom
as an easy workaround, but it'd be nice not to have the extra dependency just so I can import Provider and connectWhich versions of React, ReactDOM/React Native, Redux, and React Redux are you using? Which browser and OS are affected by this issue? Did this work in previous versions of React Redux?
React: 16.11.0
ReactDOM/React Native: N/A
ink: 2.5.0
Redux: 4.0.4
React Redux: 7.1.3
The text was updated successfully, but these errors were encountered: