Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add direction null check #3647

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

Edivad99
Copy link
Contributor

@Edivad99 Edivad99 commented Mar 7, 2024

Fixed an error that occurred when targeting the crafter with Jade installed

Caused by: java.lang.NullPointerException: Cannot invoke "net.minecraft.core.Direction.equals(Object)" because "direction" is null
	at com.refinedmods.refinedstorage.blockentity.CrafterBlockEntity.getPatterns(CrafterBlockEntity.java:48) ~[refinedstorage-1.13.0-beta.3.jar%23189!/:?] {re:classloading}
	at net.neoforged.neoforge.capabilities.RegisterCapabilitiesEvent.lambda$registerBlockEntity$1(RegisterCapabilitiesEvent.java:64) ~[neoforge-20.4.192.jar%23184%23187!/:?] {re:classloading}
	at net.neoforged.neoforge.capabilities.BlockCapability.getCapability(BlockCapability.java:158) ~[neoforge-20.4.192.jar%23184%23187!/:?] {re:classloading}
	at net.neoforged.neoforge.common.extensions.ILevelExtension.getCapability(ILevelExtension.java:74) ~[neoforge-20.4.192.jar%23184%23187!/:?] {re:classloading}
	at snownee.jade.util.CommonProxy.findItemHandler(CommonProxy.java:220) ~[jade-324717-5109393.jar%23190!/:13.3.1] {re:classloading}
	at snownee.jade.util.CommonProxy.createItemCollector(CommonProxy.java:170) ~[jade-324717-5109393.jar%23190!/:13.3.1] {re:classloading}
	at snownee.jade.addon.universal.ItemStorageProvider.lambda$getGroups$4(ItemStorageProvider.java:244) ~[jade-324717-5109393.jar%23190!/:13.3.1] {re:classloading}

@raoulvdberge
Copy link
Collaborator

Hello, can you fix the merge conflict by rebasing on develop? Thank you.

@Edivad99
Copy link
Contributor Author

Edivad99 commented Mar 7, 2024

@raoulvdberge done 👍🏻

@raoulvdberge raoulvdberge merged commit 054bc75 into refinedmods:develop Mar 7, 2024
4 checks passed
@raoulvdberge
Copy link
Collaborator

Thank you

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants