-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: APP-396 two decimal digits for usd amount #2544
base: dev
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
✅ Deploy Preview for terrasos ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@erikalogie one thing to consider is if we want to round up the currency amount when in USD because when we cut the decimals o two we may end up charging less than the actual credits price - let me know what you think |
@erikalogie @S4mmyb any thoughts on this? |
I think we should round. |
I think we should round up to $10.90 in this case |
Ok so if it were $10.894, we would charge 10.89. |
Yep! <5 we round down, >=5 round up for that third decimal place. |
Description
https://regennetwork.atlassian.net/browse/APP-396
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...