Skip to content

Commit 017df2e

Browse files
Merge pull request #205 from regulaforensics/fix/41669
41669 - Rollback fieldType type
2 parents bdbd7a8 + ca909ec commit 017df2e

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

client/src/main/generated/com/regula/documentreader/webclient/model/ImagesField.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public class ImagesField {
4545

4646
@SerializedName(SERIALIZED_NAME_FIELD_TYPE)
4747
@javax.annotation.Nonnull
48-
private Integer fieldType;
48+
private GraphicFieldType fieldType;
4949

5050
public static final String SERIALIZED_NAME_VALUE_LIST = "valueList";
5151

@@ -80,22 +80,22 @@ public void setFieldName(@javax.annotation.Nonnull String fieldName) {
8080
this.fieldName = fieldName;
8181
}
8282

83-
public ImagesField fieldType(@javax.annotation.Nonnull Integer fieldType) {
83+
public ImagesField fieldType(@javax.annotation.Nonnull GraphicFieldType fieldType) {
8484
this.fieldType = fieldType;
8585
return this;
8686
}
8787

8888
/**
89-
* The value can be from GraphicFieldType or TextFieldType enum.
89+
* Get fieldType
9090
*
9191
* @return fieldType
9292
*/
9393
@javax.annotation.Nonnull
94-
public Integer getFieldType() {
94+
public GraphicFieldType getFieldType() {
9595
return fieldType;
9696
}
9797

98-
public void setFieldType(@javax.annotation.Nonnull Integer fieldType) {
98+
public void setFieldType(@javax.annotation.Nonnull GraphicFieldType fieldType) {
9999
this.fieldType = fieldType;
100100
}
101101

@@ -238,6 +238,8 @@ public static void validateJsonElement(JsonElement jsonElement) throws IOExcepti
238238
"Expected the field `fieldName` to be a primitive type in the JSON string but got `%s`",
239239
jsonObj.get("fieldName").toString()));
240240
}
241+
// validate the required field `fieldType`
242+
GraphicFieldType.validateJsonElement(jsonObj.get("fieldType"));
241243
// ensure the json data is an array
242244
if (!jsonObj.get("valueList").isJsonArray()) {
243245
throw new IllegalArgumentException(

client/src/main/java/com/regula/documentreader/webclient/model/ext/Images.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public Images withFieldList(List<ImagesField> fieldList) {
4747
@Nullable
4848
public ImagesField getField(GraphicFieldType fieldType) {
4949
for (com.regula.documentreader.webclient.model.ImagesField field : getFieldList()) {
50-
if (field.getFieldType().equals(fieldType.getValue())) {
50+
if (field.getFieldType() == fieldType) {
5151
return new ImagesField(field);
5252
}
5353
}
@@ -57,7 +57,7 @@ public ImagesField getField(GraphicFieldType fieldType) {
5757
public List<ImagesField> getFields(int fieldType) {
5858
List<ImagesField> fields = new ArrayList<>();
5959
for (com.regula.documentreader.webclient.model.ImagesField field : getFieldList()) {
60-
if (field.getFieldType() == fieldType) {
60+
if (field.getFieldType().getValue() == fieldType) {
6161
fields.add(new ImagesField(field));
6262
}
6363
}

client/src/main/java/com/regula/documentreader/webclient/model/ext/ImagesField.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public ImagesField withFieldName(String fieldName) {
2020
}
2121

2222
public ImagesField withFieldType(GraphicFieldType fieldType) {
23-
this.setFieldType(fieldType.getValue());
23+
this.setFieldType(fieldType);
2424
return this;
2525
}
2626

0 commit comments

Comments
 (0)