Make signatures forward-comaptible with doctrine/persistence 4.x

These changes are the first of migration toward doctrine/persistence 4.0.
Most of the signatures that could've been made compatible have been made compatible.
There are some other, which require more in-depth knowledge of repository to adjust / rework.

Author: rela589n

lib/Doctrine/ODM/PHPCR/Decorator/DocumentManagerDecorator.php

@@ -7,6 +7,7 @@
 use Doctrine\ODM\PHPCR\ChildrenCollection;
 use Doctrine\ODM\PHPCR\Configuration;
 use Doctrine\ODM\PHPCR\DocumentManagerInterface;
+use Doctrine\ODM\PHPCR\Mapping\ClassMetadata as PhpcrClassMetadata;
 use Doctrine\ODM\PHPCR\Proxy\ProxyFactory;
 use Doctrine\ODM\PHPCR\Query\Builder\QueryBuilder;
 use Doctrine\ODM\PHPCR\Query\Query;
@@ -38,6 +39,12 @@ public function __construct(DocumentManagerInterface $wrapped)
         $this->wrapped = $wrapped;
     }
 
+    /** @noinspection SenselessMethodDuplicationInspection - return type is made more specific to match {@see DocumentManagerInterface::getClassMetadata()} */
+    public function getClassMetadata(string $className): PhpcrClassMetadata
+    {
+        return $this->wrapped->getClassMetadata($className);
+    }
+
     public function setTranslationStrategy(string $key, TranslationStrategyInterface $strategy): void
     {
         $this->wrapped->setTranslationStrategy($key, $strategy);

lib/Doctrine/ODM/PHPCR/DocumentManagerInterface.php

@@ -45,13 +45,11 @@
 interface DocumentManagerInterface extends ObjectManager
 {
     /**
-     * @{@inheritDoc}
-     *
-     * Overwritten to tighten return type. We can't tighten the return type declaration because of Doctrine\Persistence\ObjectManagerDecorator.
+     * {@inheritdoc}
      *
-     * @return PhpcrClassMetadata
+     * Overwritten to tighten the return type.
      */
-    public function getClassMetadata(string $className);
+    public function getClassMetadata(string $className): PhpcrClassMetadata;
 
     /**
      * Add or replace a translation strategy.

lib/Doctrine/ODM/PHPCR/Mapping/ClassMetadata.php

@@ -1317,7 +1317,7 @@ public function getAssociationTargetClass($fieldName): ?string
         return $this->mappings[$fieldName]['targetDocument'];
     }
 
-    public function getAssociationMappedByTargetField($assocName)
+    public function getAssociationMappedByTargetField($assocName): string
     {
         throw new BadMethodCallException(sprintf(
             '%s not yet implemented in "%s"',
@@ -1326,7 +1326,7 @@ public function getAssociationMappedByTargetField($assocName)
         ));
     }
 
-    public function isAssociationInverseSide($assocName)
+    public function isAssociationInverseSide($assocName): bool
     {
         throw new BadMethodCallException(sprintf(
             '%s not yet implemented in "%s"',

lib/Doctrine/ODM/PHPCR/Mapping/Driver/AttributeDriver.php

@@ -63,7 +63,7 @@ public function __construct(array $paths)
         $this->addPaths($paths);
     }
 
-    public function isTransient($className)
+    public function isTransient($className): bool
     {
         $classAttributes = $this->reader->getClassAttributes(new \ReflectionClass($className));
 

lib/Doctrine/ODM/PHPCR/Mapping/Driver/YamlDriver.php

@@ -262,7 +262,7 @@ private function addMappingFromReference(ClassMetadata $class, string $fieldName
         }
     }
 
-    protected function loadMappingFile($file)
+    protected function loadMappingFile($file): array
     {
         if (!is_file($file)) {
             throw new InvalidArgumentException(sprintf('File "%s" not found', $file));