Skip to content

Remove validation for image type and format #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lubomir wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove validation for image type and format #166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions productmd/images.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@
"UniqueImage",
)

# Deprecated
IMAGE_TYPE_FORMAT_MAPPING = {
'boot': ['iso'],
'cd': ['iso'],
Expand Down Expand Up @@ -105,10 +106,10 @@
'vsphere-ova': ['vsphere.ova'],
}

#: supported image types
#: Deprecated. supported image types
SUPPORTED_IMAGE_TYPES = list(sorted(IMAGE_TYPE_FORMAT_MAPPING.keys()))

#: supported image formats, they match with file suffix
#: Deprecated. supported image formats, they match with file suffix
SUPPORTED_IMAGE_FORMATS = list(sorted(set(chain(*IMAGE_TYPE_FORMAT_MAPPING.values()))))

#: combination of attributes which uniquely identifies an image across composes
Expand Down Expand Up @@ -267,11 +268,9 @@ def _validate_volume_id(self):

def _validate_type(self):
self._assert_type("type", list(six.string_types))
self._assert_value("type", SUPPORTED_IMAGE_TYPES)

def _validate_format(self):
self._assert_type("format", list(six.string_types))
self._assert_value("format", SUPPORTED_IMAGE_FORMATS)

def _validate_arch(self):
self._assert_type("arch", list(six.string_types))
Expand Down