Skip to content

Commit f582575

Browse files
committedNov 8, 2018
maven to kotlin dsl migration part 2
1 parent 40f4746 commit f582575

File tree

20 files changed

+167
-120
lines changed

20 files changed

+167
-120
lines changed
 

‎benchmark/build.gradle

-14
This file was deleted.

‎benchmark/build.gradle.kts

+17
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
plugins {
2+
java
3+
}
4+
5+
dependencies {
6+
implementation(project(":core"))
7+
implementation(project(":processor"))
8+
implementation(project(":annotation"))
9+
implementation(project(":processor-common"))
10+
11+
implementation(Deps.caliper)
12+
implementation(Deps.javaPoet)
13+
implementation(Deps.simpleXml)
14+
implementation(Deps.jacksonXml)
15+
implementation(Deps.kotlinStdLib)
16+
implementation(Deps.kotlinReflect)
17+
}

‎buildSrc/src/main/java/Dependencies.kt

+31
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,24 @@ object Versions {
66
const val javaPoet = "1.11.1"
77
const val compileTesting = "0.15"
88
const val truth = "0.42"
9+
const val jackson = "2.9.7"
10+
const val simpleXml = "2.7.1"
11+
const val caliper = "1.2.1"
12+
const val okio = "2.1.0"
13+
const val assertj = "3.11.1"
14+
const val guava = "27.0-jre"
15+
const val mockito = "2.23.0"
16+
const val retrofit = "2.4.0"
17+
const val mockWebserver = "3.11.0"
918
}
1019

1120
object Deps {
1221
// testing
1322
const val junit = "junit:junit:${Versions.junit}"
1423
const val compileTesting = "com.google.testing.compile:compile-testing:${Versions.compileTesting}"
1524
const val truth = "com.google.truth:truth:${Versions.truth}"
25+
const val assertj = "org.assertj:assertj-core:${Versions.assertj}"
26+
const val mockito = "org.mockito:mockito-core:${Versions.mockito}"
1627

1728
// google auto
1829
const val autoService ="com.google.auto.service:auto-service:${Versions.autoService}"
@@ -24,5 +35,25 @@ object Deps {
2435
const val kotlinReflect = "org.jetbrains.kotlin:kotlin-reflect:${Versions.kotlin}"
2536
const val kotlinTestJunit = "org.jetbrains.kotlin:kotlin-test-junit:${Versions.kotlin}"
2637

38+
// okio
39+
const val okio = "com.squareup.okio:okio:${Versions.okio}"
40+
41+
// retrofit
42+
const val retrofit = "com.squareup.retrofit2:retrofit:${Versions.retrofit}"
43+
44+
// mockwebserver
45+
const val mockWebserver = "com.squareup.okhttp3:mockwebserver:${Versions.mockWebserver}"
46+
47+
// guava
48+
const val guava = "com.google.guava:guava:${Versions.guava}"
49+
50+
// parser
51+
const val jacksonXml = "com.fasterxml.jackson.dataformat:jackson-dataformat-xml:${Versions.jackson}"
52+
const val simpleXml = "org.simpleframework:simple-xml:${Versions.simpleXml}"
53+
54+
// code generation
2755
const val javaPoet = "com.squareup:javapoet:${Versions.javaPoet}"
56+
57+
// benachmark
58+
const val caliper = "net.trajano.caliper:caliper:${Versions.caliper}"
2859
}

‎converters/date-rfc3339/build.gradle

-6
This file was deleted.
+8
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
plugins {
2+
java
3+
}
4+
5+
dependencies {
6+
implementation(project(":core"))
7+
testCompile(Deps.junit)
8+
}

‎converters/htmlescape/build.gradle

-6
This file was deleted.
+8
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
plugins {
2+
java
3+
}
4+
5+
dependencies {
6+
implementation(project(":core"))
7+
testCompile(Deps.junit)
8+
}

‎core/build.gradle

-7
This file was deleted.

‎core/build.gradle.kts

+9
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
plugins {
2+
java
3+
}
4+
5+
dependencies {
6+
compile(Deps.okio)
7+
testImplementation(Deps.junit)
8+
testImplementation(Deps.assertj)
9+
}

‎core/src/test/java/com/tickaroo/tikxml/TypeConvertersTest.java

+23-22
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020

2121
import java.io.IOException;
2222
import java.util.Date;
23+
2324
import org.junit.Assert;
2425
import org.junit.Rule;
2526
import org.junit.Test;
@@ -30,37 +31,37 @@
3031
*/
3132
public class TypeConvertersTest {
3233

33-
@Rule
34-
public ExpectedException exception = ExpectedException.none();
34+
@Rule
35+
public ExpectedException exception = ExpectedException.none();
3536

36-
static class TestConverter implements TypeConverter<Object> {
37-
@Override
38-
public Object read(String value) throws Exception {
39-
return null;
40-
}
37+
static class TestConverter implements TypeConverter<Object> {
38+
@Override
39+
public Object read(String value) {
40+
return null;
41+
}
4142

42-
@Override
43-
public String write(Object value) throws Exception {
44-
return null;
43+
@Override
44+
public String write(Object value) {
45+
return null;
46+
}
4547
}
46-
}
4748

48-
@Test
49-
public void addAndGetTypeConverter() throws IOException {
49+
@Test
50+
public void addAndGetTypeConverter() throws IOException {
5051

51-
TypeConverters converters = new TypeConverters();
52+
TypeConverters converters = new TypeConverters();
5253

53-
exception.expect(IOException.class);
54-
converters.get(TestConverter.class);
54+
exception.expect(IOException.class);
55+
converters.get(TestConverter.class);
5556

56-
TestConverter converter = new TestConverter();
57+
TestConverter converter = new TestConverter();
5758

58-
converters.add(Object.class, converter);
59-
Assert.assertTrue(converter == converters.get(Object.class));
59+
converters.add(Object.class, converter);
60+
Assert.assertSame(converter, converters.get(Object.class));
6061

61-
exception.expect(IOException.class);
62-
converters.get(Date.class);
62+
exception.expect(IOException.class);
63+
converters.get(Date.class);
6364

6465

65-
}
66+
}
6667
}

‎core/src/test/java/com/tickaroo/tikxml/TypesTest.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,7 @@ interface StringIntegerMap extends Map<String, Integer> {
123123
}
124124

125125
@Test public void mapKeyAndValueTypes() throws Exception {
126-
Type mapOfStringIntegerType = TypesTest.class.getDeclaredField(
127-
"mapOfStringInteger").getGenericType();
126+
Type mapOfStringIntegerType = TypesTest.class.getDeclaredField("mapOfStringInteger").getGenericType();
128127
assertThat(Types.mapKeyAndValueTypes(mapOfStringIntegerType, Map.class))
129128
.containsExactly(String.class, Integer.class);
130129
}

‎processor-common/build.gradle

-8
This file was deleted.

‎processor-common/build.gradle.kts

+10
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
plugins {
2+
java
3+
id("kotlin")
4+
}
5+
6+
dependencies {
7+
compile(project(":annotation"))
8+
compile(Deps.kotlinStdLib)
9+
implementation(Deps.kotlinReflect)
10+
}

‎processor/build.gradle

-19
This file was deleted.

‎processor/build.gradle.kts

+22
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
plugins {
2+
java
3+
id("kotlin")
4+
}
5+
6+
dependencies {
7+
compile(project(":core"))
8+
compile(project(":annotation"))
9+
compile(project(":processor-common"))
10+
11+
implementation(Deps.guava)
12+
implementation(Deps.javaPoet)
13+
implementation(Deps.autoService)
14+
implementation(Deps.kotlinStdLib)
15+
implementation(Deps.kotlinReflect)
16+
17+
testImplementation(Deps.junit)
18+
testImplementation(Deps.truth)
19+
testImplementation(Deps.mockito)
20+
testImplementation(Deps.compileTesting)
21+
testImplementation(Deps.kotlinTestJunit)
22+
}

‎processor/src/test/java/com/tickaroo/tikxml/processor/TestUtils.kt

+3-3
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,15 @@ fun expectException(errorMsg: String? = null, blockToExecute: () -> Unit) {
2727
try {
2828
blockToExecute()
2929
fail("Expected an exception, but no exception has been thrown")
30-
} catch(error: AssertionError) {
30+
} catch (error: AssertionError) {
3131
throw error
32-
} catch(t: ProcessingException) {
32+
} catch (t: ProcessingException) {
3333

3434
if (errorMsg != null && errorMsg != t.message) {
3535
fail("Expected an error message \n\"$errorMsg\"\nbut got:\n\"${t.message}\"")
3636
}
3737

38-
} catch(other: Throwable) {
38+
} catch (other: Throwable) {
3939
other.printStackTrace()
4040
fail("Expected another type of exception, see stacktrace above")
4141
}

‎processor/src/test/java/com/tickaroo/tikxml/processor/XmlCharactersTest.kt

+16-19
Original file line numberDiff line numberDiff line change
@@ -9,25 +9,22 @@ import org.junit.Test
99
*/
1010
class XmlCharactersTest {
1111

12-
1312
@Test
14-
fun test(){
15-
Assert.assertTrue(XmlCharacters.containsXmlCharacter("a<"));
16-
Assert.assertTrue(XmlCharacters.containsXmlCharacter("<a"));
17-
Assert.assertTrue(XmlCharacters.containsXmlCharacter("<"));
18-
19-
20-
Assert.assertTrue(XmlCharacters.containsXmlCharacter("a>"));
21-
Assert.assertTrue(XmlCharacters.containsXmlCharacter(">a"));
22-
Assert.assertTrue(XmlCharacters.containsXmlCharacter(">"));
23-
24-
25-
Assert.assertTrue(XmlCharacters.containsXmlCharacter("a\""));
26-
Assert.assertTrue(XmlCharacters.containsXmlCharacter("\"a"));
27-
Assert.assertTrue(XmlCharacters.containsXmlCharacter("\""));
28-
29-
Assert.assertTrue(XmlCharacters.containsXmlCharacter("a'"));
30-
Assert.assertTrue(XmlCharacters.containsXmlCharacter("'a"));
31-
Assert.assertTrue(XmlCharacters.containsXmlCharacter("'"));
13+
fun test() {
14+
Assert.assertTrue(XmlCharacters.containsXmlCharacter("a<"))
15+
Assert.assertTrue(XmlCharacters.containsXmlCharacter("<a"))
16+
Assert.assertTrue(XmlCharacters.containsXmlCharacter("<"))
17+
18+
Assert.assertTrue(XmlCharacters.containsXmlCharacter("a>"))
19+
Assert.assertTrue(XmlCharacters.containsXmlCharacter(">a"))
20+
Assert.assertTrue(XmlCharacters.containsXmlCharacter(">"))
21+
22+
Assert.assertTrue(XmlCharacters.containsXmlCharacter("a\""))
23+
Assert.assertTrue(XmlCharacters.containsXmlCharacter("\"a"))
24+
Assert.assertTrue(XmlCharacters.containsXmlCharacter("\""))
25+
26+
Assert.assertTrue(XmlCharacters.containsXmlCharacter("a'"))
27+
Assert.assertTrue(XmlCharacters.containsXmlCharacter("'a"))
28+
Assert.assertTrue(XmlCharacters.containsXmlCharacter("'"))
3229
}
3330
}

‎retrofit-converter/build.gradle

-12
This file was deleted.

‎retrofit-converter/build.gradle.kts

+14
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
plugins {
2+
java
3+
}
4+
5+
dependencies {
6+
compile(project(":core"))
7+
compile(project(":annotation"))
8+
compile(Deps.retrofit)
9+
compile(Deps.kotlinStdLib)
10+
implementation(project(":processor-common"))
11+
testAnnotationProcessor(project(":processor"))
12+
testImplementation(Deps.mockWebserver)
13+
testImplementation(Deps.junit)
14+
}

‎retrofit-converter/src/test/java/com/tickaroo/tikxml/retrofit/Person.java

+5-2
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,16 @@
1818

1919
package com.tickaroo.tikxml.retrofit;
2020

21+
import com.tickaroo.tikxml.annotation.PropertyElement;
22+
import com.tickaroo.tikxml.annotation.Xml;
2123

2224
/**
2325
* @author Hannes Dorfmann
2426
*/
25-
27+
@Xml
2628
public class Person {
27-
String name;
2829

30+
@PropertyElement
31+
String name;
2932

3033
}

0 commit comments

Comments
 (0)
Please sign in to comment.