Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isla server exits on error #7

Open
dc-mak opened this issue Aug 14, 2020 · 1 comment
Open

Isla server exits on error #7

dc-mak opened this issue Aug 14, 2020 · 1 comment
Labels
enhancement New feature or request invalid This doesn't seem right question Further information is requested

Comments

@dc-mak
Copy link
Contributor

dc-mak commented Aug 14, 2020

isla-client signals when there is an error but then (quietly) breaks the loop/shuts down.

Err(msg) => break Err(msg),

Is there any particular reason for looping on success but exiting on failure?
From a read-dwarf perspective, where you can be processing a bunch of instructions, and wish to ignore any ones that Isla can't currently handle, this is surprising and hard to track down (broken pipe shows up when you try to write to it, potentially long after the failure).
Would it be possible to keep going instead of breaking or at least given some indication that Isla's shutting down?

@dc-mak dc-mak added enhancement New feature or request invalid This doesn't seem right question Further information is requested labels Aug 14, 2020
@Alasdair
Copy link
Collaborator

No particular reason. You should feel free to change that file to make it work however you need for read-dwarf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request invalid This doesn't seem right question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants