Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to chokidar 4 #2222

Open
benmccann opened this issue Sep 15, 2024 · 12 comments
Open

Upgrade to chokidar 4 #2222

benmccann opened this issue Sep 15, 2024 · 12 comments

Comments

@benmccann
Copy link

Chokidar v4 is out now. It drops a dozen dependencies, so is much smaller and lighter

@remy
Copy link
Owner

remy commented Sep 19, 2024

I need to check this fairly carefully for any breaking changes. If it's all good, then I will do, but there's no high priority to bump the dep just yet (especially as it's just come out).

@benmccann
Copy link
Author

The big breaking change is that it dropped support for glob syntax, so any glob usage needs to be handled on the user's side: https://github.com/paulmillr/chokidar?tab=readme-ov-file#upgrading

Copy link

github-actions bot commented Oct 3, 2024

This issue has been automatically marked as idle and stale because it hasn't had any recent activity. It will be automtically closed if no further activity occurs. If you think this is wrong, or the problem still persists, just pop a reply in the comments and @remy will (try!) to follow up.
Thank you for contributing <3

@github-actions github-actions bot added the stale no activity for 2 weeks label Oct 3, 2024
@benmccann
Copy link
Author

Still exists as a to-do

@github-actions github-actions bot removed the stale no activity for 2 weeks label Oct 3, 2024
Copy link

This issue has been automatically marked as idle and stale because it hasn't had any recent activity. It will be automtically closed if no further activity occurs. If you think this is wrong, or the problem still persists, just pop a reply in the comments and @remy will (try!) to follow up.
Thank you for contributing <3

@github-actions github-actions bot added the stale no activity for 2 weeks label Oct 17, 2024
@benmccann
Copy link
Author

Still exists as a to-do

@github-actions github-actions bot removed the stale no activity for 2 weeks label Oct 17, 2024
Copy link

This issue has been automatically marked as idle and stale because it hasn't had any recent activity. It will be automtically closed if no further activity occurs. If you think this is wrong, or the problem still persists, just pop a reply in the comments and @remy will (try!) to follow up.
Thank you for contributing <3

@github-actions github-actions bot added the stale no activity for 2 weeks label Oct 31, 2024
@benmccann
Copy link
Author

Still exists as a to-do

@github-actions github-actions bot removed the stale no activity for 2 weeks label Oct 31, 2024
@lgugla
Copy link

lgugla commented Nov 12, 2024

Any update here as in chokidar 3.6 there is a dependency of braces package which have a high vulnerability reported in our scans. As in chokidar 4 this dependency is removed and the vulnerability will get auto fixed.

Please update to chokidar 4.x so that vulnerability get fixed in this package.
image

@remy
Copy link
Owner

remy commented Nov 12, 2024

@lgugla it's worth doing your reading rather than blindly reporting what vuln auto tools report: #2203

You're not alone though, often vulns are reported when they're nonsense.

@remy
Copy link
Owner

remy commented Nov 12, 2024

I'm guessing no one has wanted to contribute to this issue to see if it breaks backward support, so I'll do it when I've got time.

I'm guessing the only tangible benefit is ticking that security box around the false positive flag on braces, or is there something else that's significantly better? (this will help inform the priority)

@benmccann
Copy link
Author

As mentioned in the issue description, it also drops a dozen dependencies so results in smaller installs and less supply chain risk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants