-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Description
Context
The command palette feature (#TBD) introduces domain.Actions as the canonical source of truth for what actions exist in the system. However, other components still read from different sources:
| Component | Currently reads from |
|---|---|
| Help screen | KeyMap → KeyDefinitions |
| Tips | KeyDefinitions.TipFormat |
| Command palette | domain.Actions (new) |
This creates inconsistency and potential for drift.
Proposed Change
Refactor the system so that:
domain.Actionsis the canonical action catalog (Name, Description, RequiresSession)KeyDefinitionsreferences action names and adds shortcut-specific info (Defaults, TipFormat)- Help screen and tips derive their content by linking these two sources
Benefits
- Single source of truth for action metadata
- Consistent descriptions across all UI surfaces
- Easier to add new actions (define once in domain, wire up shortcuts in UI)
Files to Modify
internal/ui/help_screen.go- Read from domain.Actions + KeyDefinitionsinternal/ui/keys_types.go- Tips should link to domain.Actions- Potentially consolidate action-related code
Related
- Command palette design:
docs/plans/2025-01-29-command-palette-design.md
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels