Sublime_zk highlights tags in all open files of all extensions and syntaxes

[IntendedConsequence]

I spent some time reading the code, commenting lines here and there and found out that these three methods receive events for absolutely all views and modify them. I put if 'sublime_zk' in view.settings().get('syntax'): in the beginning of these methods and looks like it stopped that heresy.

sublime_zk/sublime_zk.py

Lines 2371 to 2382 in f8336c1

	def on_activated(self, view):
	self.update_note_link_highlights(view)
	# Async listeners for ST3
	def on_load_async(self, view):
	global AUTO_SHOW_IMAGES
	self.update_note_link_highlights_async(view)
	if AUTO_SHOW_IMAGES:
	view.run_command('zk_show_images')
	def on_modified_async(self, view):
	self.update_note_link_highlights_async(view)

[renerocksai]

Wow! Yeah, well spotted! It never bothered me, I am not even sure I ever noticed it. Good catch! Put on my list :-) Thx -Rene

…

On Sun, Dec 23, 2018 at 6:29 PM C T ***@***.***> wrote: I spent some time reading the code, commenting lines here and there and found out that these three methods receive events for absolutely all views and modify them. I put if 'sublime_zk' in view.settings().get('syntax'): in the beginning of these methods and looks like it stopped that heresy. https://github.com/renerocksai/sublime_zk/blob/f8336c167546bf609d0abc998fc7364795beb18e/sublime_zk.py#L2371-L2382 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#88>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Addgpz7nuXzfsdutPz3zb4HVcXoBg1nRks5u771sgaJpZM4Zf7NV> .

[arcturus140]

not only does this affect highlighting. Every file is processed by the plugin. For example for the file main.cc

#include <iostream>

a new tag is added called include.