Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we set prefixed amounts for users to deposit? #3

Open
acuarica opened this issue Nov 26, 2021 · 4 comments
Open

Should we set prefixed amounts for users to deposit? #3

acuarica opened this issue Nov 26, 2021 · 4 comments
Milestone

Comments

@acuarica
Copy link
Contributor

Migrated from card https://github.com/Ethernautas/renpool/projects/1#card-66247820

Instead of allowing the user to insert any amount to deposit, they should be presented with a set of predefined amounts to choose from, for example, 5k, 10k, 20k, 25k.

This could be set on pool creation. For instance one pool might be for 5k deposits, while other might be for 10k and so on.

@acuarica acuarica changed the title Should we set prefixed amounts for the users to deposit, like 5k, 10k, 20k, 25k? Should we set prefixed amounts for the users to deposit? Nov 26, 2021
@acuarica acuarica changed the title Should we set prefixed amounts for the users to deposit? Should we set prefixed amounts for users to deposit? Nov 26, 2021
@acuarica acuarica transferred this issue from renpool/renpool-contracts Nov 26, 2021
@acuarica
Copy link
Contributor Author

I've moved this to the app repo. I assume that this feature is part of the client: the contract itself allows a user to deposit any amount, including decimal. Is this correct @fede-rodes?

@acuarica acuarica added this to the Fine-tune UX milestone Nov 27, 2021
@fede-rodes
Copy link
Contributor

fede-rodes commented Nov 27, 2021

I think this is a feature that should be implemented in both the front and backend (users could bypass the FE). Also, this is related with the kind of approach we want to follow. In case we go the Lido way, no minimum amount should be required. However, if we allow users to deploy their own pools, then we should probably set prefixed amounts to avoid situations where small amount are missing to complete the pool target (no one will be willing to pay a high transaction fee to deposit a small amount of tokens just to fulfill the pool)

@acuarica
Copy link
Contributor Author

I see it more on the client side. The contract does not need to know how much is missing to complete the pool. To remediate the small amount issue, at most we could define that the last deposit, i.e., the one that locks the pool, should be greater than some amount.

But on the client we could have some predefined values to select from and no decimals.

@fede-rodes
Copy link
Contributor

ok, let’s iterate over this to understand what other options we have

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants