New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is the `onlyOwner` modifier being used? #28

Open

acuarica opened this issue Nov 27, 2021 · 0 comments

Labels

refactor review

Milestone

Contributor

acuarica commented Nov 27, 2021

It seems we are currently not using this modifier.

renpool-contracts/contracts/RenPool.sol

Lines 102 to 108 in 3e21148

    
           modifier onlyOwner() { 
        
           	require ( 
        
           		msg.sender == owner, 
        
           		"RenPool: Caller is not owner" 
        
           	); 
        
           	_; 
        
           }

We might need to review whether the Owner of the contract is allowed to do some special or just earn fees for being the owner.

acuarica added review refactor labels

acuarica added this to the MVP milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment