Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard coded Gas Limit to allow arbitrary contract code registration. #38

Open
jfarid27 opened this issue May 28, 2020 · 0 comments

Comments

@jfarid27
Copy link

Description

Currently, you cannot use arbitrary contract code to call on a registration for a darknode because of the hard coded gas limit found here:

const hardCodedGas = 500000;

Steps to Reproduce

  1. Try to approve an Aragon Agent to register a darknode. Console will error with gas required exceeds allowance (10000000) or always failing transaction.

Possible Fixes

  • Remove the hard coded gas limit. I believe this should fix things.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant