Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cog throws "unknown flag: --load" error when buildx isn't installed #1713

Open
jessie-young opened this issue Jun 3, 2024 · 2 comments
Open
Assignees

Comments

@jessie-young
Copy link
Contributor

When buildx isn't installed, running cog commands such as cog predict throws an error unknown flag --load.

Either have cog output a more user-friendly error, or there might be some other fix. Thread from slack:

Thread, for context:
sylvie
maybe we could introspect to find out if buildx is installed

marcus
26 minutes ago
I think just checking for docker buildx version should be enough

sylvie
25 minutes ago
I don't think we used to require it to be installed, though I'm not sure if RUN --mount is a thing outside buildx

jessie.young
19 minutes ago
@sylvie
i manually checked using docker builedx version to see if it was installed after i installed docker, and it wasn’t

sylvie
18 minutes ago
I mean, before we added --load to deal with the GHA thing, I don't believe buildx was required

@zeke
Copy link
Member

zeke commented Jun 5, 2024

cc @EduarteXD I think this might be a regression from the related PRs we merged recently.

@EduarteXD
Copy link
Contributor

cc @EduarteXD I think this might be a regression from the related PRs we merged recently.

The load flag was removed in #1656, consider merging it and replicate/setup-cog#36.

This flag was intended to solve the problem of passing products in instances of buildx, which is no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants