Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base image cuda12.4-python3.12-torch2.5.1 ffmpeg is missing #2121

Closed
bzikst opened this issue Jan 23, 2025 · 7 comments
Closed

Base image cuda12.4-python3.12-torch2.5.1 ffmpeg is missing #2121

bzikst opened this issue Jan 23, 2025 · 7 comments
Assignees

Comments

@bzikst
Copy link

bzikst commented Jan 23, 2025

Config with base image r8.im/cog-base:cuda12.4-python3.12-torch2.5.1 seems to be missing ffmpeg. Adding it in system_packages wont help — I think because cog is removing ffmpeg from deps and assumes all base images already have it.

I'm using this command to build
cog build --separate-weights --use-cog-base-image

The workaround I use for now is run section:
--mount=type=cache,target=/var/cache/apt,sharing=locked apt-get update -qq && apt-get install -qqy ffmpeg && rm -rf /var/lib/apt/lists/*

@8W9aG 8W9aG self-assigned this Jan 23, 2025
@8W9aG
Copy link
Contributor

8W9aG commented Jan 23, 2025

I've added this integration test: #2122
It seems to be passing, which I believe means that a fix we made previously solves this, we just need to re-release cog. I will cut a new release tomorrow which should sort this out for you.

@8W9aG
Copy link
Contributor

8W9aG commented Jan 24, 2025

Alright just released 0.13.7 let me know if this is solving your problem. Re-open the issue if it isn't the case.

@8W9aG 8W9aG closed this as completed Jan 24, 2025
@bzikst
Copy link
Author

bzikst commented Jan 25, 2025

Unfortunatelly, 0.13.7 release changed nothing to me in this case. I've reproduced integration test you've added and it works ok with Python 3.9 and failes with Python 3.12.

Can you please try this cog.yaml?

build:
  gpu: true
  python_version: "3.12"
  python_packages:
    - "torch==2.5.1"
  cuda: "12.4"
  run:
    - command: ffmpeg --help
predict: "predict.py:Predictor"

It uses r8.im/cog-base:cuda12.4-python3.12-torch2.5.1 and outputs /bin/sh: 1: ffmpeg: not found

@8W9aG 8W9aG reopened this Jan 28, 2025
@8W9aG
Copy link
Contributor

8W9aG commented Jan 28, 2025

@bzikst sorry about that I'll give that a try today and see if I can't get this working for you

@8W9aG
Copy link
Contributor

8W9aG commented Jan 28, 2025

OK I am able to replicate the issue here: #2131
Let me come up with a fix

@8W9aG
Copy link
Contributor

8W9aG commented Jan 28, 2025

Alright I have released a new base image which appears to fix this (so no cog update required), can you let me know what happens if you attempt this now? @bzikst

@bzikst
Copy link
Author

bzikst commented Jan 28, 2025

can you let me know what happens if you attempt this now?

Yes, it's working as expected now. Thank you for a quick fix!

@bzikst bzikst closed this as completed Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants