Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DefaultHttpClientFactory friendly for consumers #115

Open
nvborisenko opened this issue Mar 17, 2023 · 0 comments
Open

Make DefaultHttpClientFactory friendly for consumers #115

nvborisenko opened this issue Mar 17, 2023 · 0 comments

Comments

@nvborisenko
Copy link
Member

This is continuation of #114

We have DefaultHttpClientFactory which is used implicitly. At the same time the main consumer uses his own implementation: https://github.com/reportportal/commons-net/blob/bd375443c1e6c918720ac47587e0b4674ee6c98d/src/ReportPortal.Shared/Reporter/Http/HttpClientFactory.cs#LL44C12-L44C12

I guess 99% is similar. It would be better if the implementation can be exposed, and consumer is able to extend default implementation via inheritance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant