Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move logic of logs amender to RequestNormalizer #139

Open
nvborisenko opened this issue Mar 4, 2023 · 0 comments
Open

Move logic of logs amender to RequestNormalizer #139

nvborisenko opened this issue Mar 4, 2023 · 0 comments
Labels
pri:low

Comments

@nvborisenko
Copy link
Member

https://github.com/reportportal/commons-net/blob/4f9616960155763841c95e7a36656fa06977566f/src/ReportPortal.Shared/Reporter/LaunchLogRequestAmender.cs#L5

Looks like we can move this responsibility to existing extension, who is normalizing all http requests (ReportPortal.Shared.Extensibility.Embedded.Normalization). This is continuation of reportportal/commons-net#121
@nvborisenko nvborisenko transferred this issue from reportportal/commons-net Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pri:low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nvborisenko