-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heuristic stacks video frames rather than giving them their own 2d views #7821
Labels
Milestone
Comments
In particular: |
Part of the work is done in: For the second half, we need to do one or both of the following:
|
emilk
added a commit
that referenced
this issue
Oct 22, 2024
### What * Part of #7821 * Bonus: better profiling of video loading The change is that `MaxImageDimensionSubscriber` parses each `.mp4` to figure out its size… …except I disabled that check last-second because we don't have access to the `VideoCache`, and so this PR would lead to each video getting parsed _twice_. Still, I would like to get this PR merged as a necessary refactor and generally improved structure. This is where we're heading:  ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7850?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7850?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/7850) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
emilk
added a commit
that referenced
this issue
Oct 23, 2024
Ensures each video gets its own space-view. * Closes #7821
I'm still getting that error. For instance when using the video check from the checklist (update incoming) without a blueprint |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
VideoAssets should follow the same heuristics as images
The text was updated successfully, but these errors were encountered: