Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to change the color of the Pinhole camera frustum (currently it's always gray) #8572

Open
rjeye opened this issue Jan 3, 2025 · 0 comments
Labels
enhancement New feature or request 🏎️ Quick Issue Can be fixed in a few hours or less 📺 re_viewer affects re_viewer itself

Comments

@rjeye
Copy link

rjeye commented Jan 3, 2025

Is your feature request related to a problem? Please describe.
It'd be great if Pinhole had a color parameter that can be set - currently the camera frustum's lines are alway gray by default. Having the lines be a different color would help easily differentiate between different cameras - such as query vs reference vs prediction in visual localization etc.

Describe the solution you'd like
An additional color parameter for rr.Pinhole which would look like:

rr.log(
f"world/camera_{frame_id}/image",
rr.Pinhole(
resolution=[W, H],
focal_length=[K[0, 0], K[1, 1]],
principal_point=[K[0, 2], K[1, 2]],
### color=[255,127,80], # RGB for coral!
),
)

Describe alternatives you've considered
One possible albeit tedious method could always be to build this ourselves using LineStrips3D - but that's clearly a workaround.

Additional context
Taken from https://nianticlabs.github.io/mickey/. Coloring different cameras would help visually distinguish between different baselines, or color the camera estimate a certain color based on its pose error.

Image

@rjeye rjeye added enhancement New feature or request 👀 needs triage This issue needs to be triaged by the Rerun team labels Jan 3, 2025
@Wumpf Wumpf added 📺 re_viewer affects re_viewer itself 🏎️ Quick Issue Can be fixed in a few hours or less and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 🏎️ Quick Issue Can be fixed in a few hours or less 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

No branches or pull requests

2 participants