Use v2 of the ROR API

[ewan-escience]

Use v2 of the ROR API

Changes proposed in this pull request

• Use v2 of the ROR API

How to test

• docker compose down --volumes && docker compose build --parallel && docker compose up --scale data-generation=1
• Sign in as admin
• Add organisations in the admin panel or add organisations to software/project pages
• docker compose exec scrapers java -cp /usr/myjava/scrapers.jar nl.esciencecenter.rsd.scraper.ror.MainRor
• The scraper should run without errors (check the error logs)
• http://localhost/api/v1/organisation?ror_id=not.is.null&order=ror_scraped_at.desc.nullslast should show that organisations were recently harvested

closes #1597

PR Checklist:

• Increase version numbers in docker-compose.yml
• Link to a GitHub issue
• Update documentation
• Tests

[jmaassen]

Works as expected. The readability of these statements in MainRor.java could improve though;

Double lat = latJson != null && latJson.isJsonPrimitive()
				? latJson.getAsJsonPrimitive().getAsDouble()
				: null;

My internal type checker triggered a few times with an error before I realize that the && gets priority over the ? ;-)

I would put the expression before the ? between brackets for readability, so:

Double lat = (latJson != null && latJson.isJsonPrimitive())
				? latJson.getAsJsonPrimitive().getAsDouble()
				: null;

[sonarqubecloud]

Quality Gate passed for 'scrapers'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
75.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sonarqubecloud]

Quality Gate failed for 'rsd-frontend'

Failed conditions
29.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud