Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always panic through utils.Assert #112

Open
dfarr opened this issue Nov 14, 2023 · 4 comments
Open

Always panic through utils.Assert #112

dfarr opened this issue Nov 14, 2023 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dfarr
Copy link
Member

dfarr commented Nov 14, 2023

Sometimes when we encounter an intolerable error we call panic() directly, instead we could call utils.Assert(false, ...) that way we would have the opportunity to optionally turn off strict panicing in production.

@dfarr dfarr added the enhancement New feature or request label Nov 14, 2023
@guergabo
Copy link
Contributor

this would be nice to expose as a flag like --strict

@guergabo guergabo added the good first issue Good for newcomers label Nov 19, 2023
@KannappanChida
Copy link

@guergabo I'm interested to work on this enhancement, can i work on this issue

@guergabo
Copy link
Contributor

guergabo commented Dec 7, 2023

@KannappanChida. of course. lmk if you need any help. thank you !

@guergabo
Copy link
Contributor

guergabo commented Jan 21, 2024

interesting approach at sqlite. They have different behaviors for asserts depending on the build: https://www.sqlite.org/assert.html#:~:text=In%20SQLite%2C%20the%20presence%20of,about%20the%20truth%20of%20X.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants