Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀] Make update state inline to improve performance #117

Open
Nek-12 opened this issue Dec 2, 2024 · 1 comment
Open

[🚀] Make update state inline to improve performance #117

Nek-12 opened this issue Dec 2, 2024 · 1 comment
Assignees
Milestone

Comments

@Nek-12
Copy link
Member

Nek-12 commented Dec 2, 2024

We have a performance bottleneck with state updates because updateState is not inline. Additionally, it causes extremely annoying importing difficulties as the extension method has lower priority than the member.

This change will be a breaking source change, as no deprecation cycle is possible on the original method, or it will not be replaced automatically in the IDE. I should evaluate this on a bigger project internally to ensure there are no entire-codebase-refactorings.

@Nek-12 Nek-12 added feature triage Needs triaging labels Dec 2, 2024
@Nek-12 Nek-12 added this to the 3.1 milestone Dec 2, 2024
@Nek-12 Nek-12 self-assigned this Dec 2, 2024
@Nek-12 Nek-12 changed the title [⏱️] Breaking: Make update state inline to update performance [⏱️] Breaking: Make update state inline to improve performance Dec 2, 2024
@Nek-12 Nek-12 moved this from Backlog to In Progress in FlowMVI Roadmap Dec 5, 2024
@Nek-12 Nek-12 removed the triage Needs triaging label Dec 5, 2024
@Nek-12 Nek-12 linked a pull request Dec 5, 2024 that will close this issue
@Nek-12 Nek-12 moved this from In Progress to Backlog in FlowMVI Roadmap Dec 8, 2024
@Nek-12 Nek-12 modified the milestones: 3.1, 4.0 Dec 8, 2024
@Nek-12
Copy link
Member Author

Nek-12 commented Dec 8, 2024

I successfully inlined updateStateImmediate but inlining updateState is a huge refactoring and the function is also used extensively. It brings marginal performance benefits compared to the non-inline function. Will move to 4.0

@Nek-12 Nek-12 removed the feature label Dec 8, 2024
@Nek-12 Nek-12 changed the title [⏱️] Breaking: Make update state inline to improve performance [🚀] Make update state inline to improve performance Dec 8, 2024
@Nek-12 Nek-12 removed a link to a pull request Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant