Fixes #1278 #1291
Closed
Fixes #1278 #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The title |
violetadev
reviewed
Sep 8, 2024
Comment on lines
+51
to
+58
| setTimeout(() => { | ||
| setName(''); | ||
| setWidth(400); | ||
| setHeight(600); | ||
| setUserAgent(''); | ||
| setType('phone'); | ||
| setDpr(1); | ||
| }, 500); |
There was a problem hiding this comment.
using setTimeout is not a good practice in general, I think that this might be more of a race condition issue. Have you looked at the order of the setStates?
violetadev
reviewed
Sep 8, 2024
| @@ -86,7 +86,7 @@ balanced-match@^1.0.0: | |||
| resolved "https://registry.npmjs.org/balanced-match/-/balanced-match-1.0.2.tgz" | |||
| integrity sha512-3oSeUO0TMV67hN1AmbXsK4yaqU7tjiHlbxRDZOpH0KW9+CeX4bRAaX0Anxt0tx2MrpRpWwQaPwIlISEJhYU5Pw== | |||
|
|
|||
| base64id@~2.0.0, [email protected]: | |||
| [email protected], base64id@~2.0.0: | |||
There was a problem hiding this comment.
yarn.lock should not be updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Pull Request
📓 Referenced Issue
Fixes: #1278
ℹ️ About the PR
Added a setTimeout in responsively-app/desktop-app/src/renderer/components/DeviceManager/DeviceDetailsModal.tsx at line number 51
To fix the Custom Device Information Flickering
🖼️ Testing Scenarios / Screenshots
Issue:
Fixes:
Screen.Recording.2024-08-27.171026.mp4