Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/767 accept language #1334

Merged

Conversation

happymvp
Copy link
Contributor

@happymvp happymvp commented Oct 28, 2024

✨ Pull Request

📓 Referenced Issue

Resolves: #767

ℹ️ About the PR

Added new setting section with Request Headers parameter.

Potentially interesting topic to discuss: Adding default values resolution as described in sindresorhus/electron-store#92.

For me this is valid issue and default value of electron store never showed up.

🖼️ Testing Scenarios / Screenshots

Screenshot 2024-10-28 at 08 24 38 Screenshot 2024-10-28 at 08 24 29 Screenshot 2024-10-28 at 08 25 57 Screenshot 2024-10-28 at 08 26 05

@CLAassistant
Copy link

CLAassistant commented Oct 28, 2024

CLA assistant check
All committers have signed the CLA.

@happymvp
Copy link
Contributor Author

Test / test (macos-latest) (pull_request) error: Error: node_modules/@jest/environment/build/index.d.ts(327,26): error TS2430: Interface 'JestImportMeta' incorrectly extends interface 'ImportMeta'.

Doesn't seem like error I should deal with as part of this PR

@violetadev
Copy link
Contributor

Test / test (macos-latest) (pull_request) error: Error: node_modules/@jest/environment/build/index.d.ts(327,26): error TS2430: Interface 'JestImportMeta' incorrectly extends interface 'ImportMeta'.

Doesn't seem like error I should deal with as part of this PR

I am not able to merge this pr until this has been resolved, it simply doesn't let me merge with pipeline errors, and it seems that this has been raised from your changes as we merged other prs just fine before this one. Could you take a look?
Thanks

@happymvp happymvp force-pushed the feature/767-accept_language branch from 59b4e64 to 4006b93 Compare November 1, 2024 14:14
@happymvp
Copy link
Contributor Author

happymvp commented Nov 1, 2024

Test / test (macos-latest) (pull_request) error: Error: node_modules/@jest/environment/build/index.d.ts(327,26): error TS2430: Interface 'JestImportMeta' incorrectly extends interface 'ImportMeta'.
Doesn't seem like error I should deal with as part of this PR

I am not able to merge this pr until this has been resolved, it simply doesn't let me merge with pipeline errors, and it seems that this has been raised from your changes as we merged other prs just fine before this one. Could you take a look? Thanks

Now everything is correct

@violetadev violetadev merged commit b0d261b into responsively-org:main Nov 1, 2024
4 checks passed
@violetadev
Copy link
Contributor

thank you for your contributions!

@all-contributors Please add @happymvp for code

Copy link
Contributor

@violetadev

I've put up a pull request to add @happymvp! 🎉

@violetadev
Copy link
Contributor

@all-contributors Please add @happymvp for test

Copy link
Contributor

@violetadev

I've updated the pull request to add @happymvp! 🎉

@happymvp happymvp deleted the feature/767-accept_language branch November 1, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can you change the Accept-language?
3 participants