-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/767 accept language #1334
Feature/767 accept language #1334
Conversation
Test / test (macos-latest) (pull_request) error: Error: node_modules/@jest/environment/build/index.d.ts(327,26): error TS2430: Interface 'JestImportMeta' incorrectly extends interface 'ImportMeta'. Doesn't seem like error I should deal with as part of this PR |
I am not able to merge this pr until this has been resolved, it simply doesn't let me merge with pipeline errors, and it seems that this has been raised from your changes as we merged other prs just fine before this one. Could you take a look? |
59b4e64
to
4006b93
Compare
Now everything is correct |
thank you for your contributions! @all-contributors Please add @happymvp for code |
I've put up a pull request to add @happymvp! 🎉 |
@all-contributors Please add @happymvp for test |
I've updated the pull request to add @happymvp! 🎉 |
✨ Pull Request
📓 Referenced Issue
Resolves: #767
ℹ️ About the PR
Added new setting section with Request Headers parameter.
Potentially interesting topic to discuss: Adding default values resolution as described in sindresorhus/electron-store#92.
For me this is valid issue and default value of electron store never showed up.
🖼️ Testing Scenarios / Screenshots