From d7d594903b30e516ad769970e3566c848ae89a0a Mon Sep 17 00:00:00 2001
From: Jack Kleeman <jackkleeman@gmail.com>
Date: Wed, 15 Nov 2023 09:03:11 +0000
Subject: [PATCH] Avoid global dyn rpc descriptor (#178)

Mutating is fine, but ensure its scoped to the base server - someone might have multiple servers created somewhere inside their application with the same names - this currently would cause a conflict
---
 src/server/base_restate_server.ts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/server/base_restate_server.ts b/src/server/base_restate_server.ts
index 0790590e..2bc446b6 100644
--- a/src/server/base_restate_server.ts
+++ b/src/server/base_restate_server.ts
@@ -62,6 +62,7 @@ export abstract class BaseRestateServer {
     HostedGrpcServiceMethod<unknown, unknown>
   > = {};
   protected readonly discovery: ServiceDiscoveryResponse;
+  protected readonly dynrpcDescriptor: RpcServiceProtoMetadata;
 
   protected constructor(protocolMode: ProtocolMode) {
     this.discovery = {
@@ -71,6 +72,7 @@ export abstract class BaseRestateServer {
       maxProtocolVersion: 0,
       protocolMode: protocolMode,
     };
+    this.dynrpcDescriptor = copyProtoMetadata(rpcServiceProtoMetadata);
   }
 
   protected addDescriptor(descriptor: ProtoMetadata) {
@@ -232,7 +234,7 @@ export abstract class BaseRestateServer {
       name.length - serviceName.length - 1
     );
 
-    const desc = dynrpcDescriptor;
+    const desc = this.dynrpcDescriptor;
     const serviceGrpcSpec = keyed
       ? pushKeyedService(desc, name)
       : pushUnKeyedService(desc, name);
@@ -555,5 +557,3 @@ function createStringKeyedMethodDescriptor(
   desc.name = methodName;
   return desc;
 }
-
-const dynrpcDescriptor = copyProtoMetadata(rpcServiceProtoMetadata);