Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restify-clients not compatible with restify 5.x #131

Open
retrohacker opened this issue Jul 28, 2017 · 1 comment
Open

restify-clients not compatible with restify 5.x #131

retrohacker opened this issue Jul 28, 2017 · 1 comment
Labels

Comments

@retrohacker
Copy link
Member

sed -i 's/restify": "^4.3.0/restify": "^5.0.0/g' package.json && make prepush


  restify-client bunyan usage tests
    ✓ no logger (48ms)
    ✓ no serializers
    ✓ bunyan stdSerializers
    ✓ some unrelated bunyan serializer "foo"
    ✓ using restify-clients exported "bunyan.serializers"

  restify-client tests
TypeError: restify.acceptParser is not a function
    at Context.<anonymous> (/home/wblankenship/Development/restify-repro/1297/node_modules/restify-clients/test/index.js:152:32)
    at callFnAsync (/home/wblankenship/Development/restify-repro/1297/node_modules/restify-clients/node_modules/mocha/lib/runnable.js:371:21)
    at Hook.Runnable.run (/home/wblankenship/Development/restify-repro/1297/node_modules/restify-clients/node_modules/mocha/lib/runnable.js:318:7)
    at next (/home/wblankenship/Development/restify-repro/1297/node_modules/restify-clients/node_modules/mocha/lib/runner.js:309:10)
    at Immediate.<anonymous> (/home/wblankenship/Development/restify-repro/1297/node_modules/restify-clients/node_modules/mocha/lib/runner.js:339:5)
    at runCallback (timers.js:672:20)
    at tryOnImmediate (timers.js:645:5)
    at processImmediate [as _immediateCallback] (timers.js:617:5)
Makefile:82: recipe for target 'test' failed
make: *** [test] Error 1
@DonutEspresso
Copy link
Member

Does this affect tests only?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants