bug(memory): gm <-> lua memory leak

[xiaoxiao921]

Klehrik says:
It seems that iterating through large (perhaps all but it's more noticeable with more elements) gamemaker arrays often (like every frame) causes a gradual memory leak(?)

Example (in __input_system_tick):

-- This causes memory usage to increase unbounded
local class_item = gm.variable_global_get("class_item")
for _, i in ipairs(class_item) do
    -- empty
    -- nothing else has to be done, just iterating causes this
end

Just open task manager and watch RoRR memory usage for a few minutes
I tried with a newly created array containing 200 0s as well and the same thing happens

---

Related code: https://github.com/return-of-modding/ReturnOfModding/blob/5a15338e95b4bb6a1b075fea9276d3056948a6d3/src/rorr/gm/pin_map.hpp

[Klehrik]

I think the problem might just be with using ipairs to iterate over it

-- This seems to be fine
local class_item = gm.variable_global_get("class_item")
local size = gm.array_length(class_item)
for i = 0, size - 1 do
    gm.array_get(class_item, i)
end

[Klehrik]

Additionally, accessing arrays with lua syntax instead of gm.array_get also causes gradual memory usage

-- This causes increasing memory usage
local class_item = gm.variable_global_get("class_item")
local size = gm.array_length(class_item)
for i = 0, size - 1 do
    local item = class_item[i]
end


-- This is fine
local class_item = gm.variable_global_get("class_item")
local size = gm.array_length(class_item)
for i = 0, size - 1 do
    local item = gm.array_get(class_item, i)
end