Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement parameter binding in extended query flow #1

Open
returnString opened this issue Apr 2, 2021 · 0 comments
Open

Implement parameter binding in extended query flow #1

returnString opened this issue Apr 2, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@returnString
Copy link
Owner

returnString commented Apr 2, 2021

Postgres' extended query flow allows clients to present a statement for parsing that contains placeholder vars ($1, $2, ...$n) and later fill in these vars at the bind phase. However, sqlparser doesn't currently support placeholders (see apache/datafusion-sqlparser-rs#145).

Once the parser supports this, we should:

  • Pass the relevant data from the stream to ClientMessage::Bind (this is presently read, but immediately discarded)
  • Update the portal interface to accept param bindings
  • Fill out a proper ParameterDescription in response to prepared statement describe requests
@returnString returnString added the enhancement New feature or request label Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant