Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSRV bump to 1.48? #125

Closed
darosior opened this issue Apr 27, 2022 · 0 comments · Fixed by #127
Closed

MSRV bump to 1.48? #125

darosior opened this issue Apr 27, 2022 · 0 comments · Fixed by #127

Comments

@darosior
Copy link
Member

revault/revaultd#390 brought to our attention more breakage of our MSRV from dependencies.

Discussing the rationale for our MSRV, it made me note that we could bump it. 1.43 is almost 2 years old and:

I think we can go with 1.48, to still support Debian stable.
@darosior darosior mentioned this issue May 2, 2022
Merged
darosior added a commit that referenced this issue May 2, 2022
@darosior
Merge #127: Bump MSRV to 1.48
8fd1bb3 
b94b4fa Bump MSRV to 1.48 (Antoine Poinsot)

Pull request description:

  Fixes #125

ACKs for top commit:
  edouardparis:
    ACK b94b4fa

Tree-SHA512: ddd5bb9c0392586a9f632b38c8a317e38955d8ca368aee80ed34b7728fd7e0a69cfc4797194c9f76bc0867134fd7530ad613e310d6ea482d65b8ddc5e0cbea69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump MSRV to 1.48 darosior/revault_tx
1 participant
@darosior