Replies: 4 comments 4 replies
-
I think there was stuff changed to support newer Java language constructs, like the updated switch statements and records types.
That's my thinking, too. Is there a ticket for the existing issue for CSS? I'm not too concerned, as I only use this formatter for Java, anyway, but would be nice to link to it. |
Beta Was this translation helpful? Give feedback.
-
|
Haven't opened one yet for css issue. Only have one know case of the issue and figured when I get to it I would just fix at same time. However will open something up this weekend.
Sent from my Verizon, Samsung Galaxy smartphone
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Christopher Tubbs ***@***.***>
Sent: Friday, January 6, 2023 1:55:04 PM
To: revelc/formatter-maven-plugin ***@***.***>
Cc: Jeremy Landis ***@***.***>; Author ***@***.***>
Subject: Re: [revelc/formatter-maven-plugin] Release 2022-12 and more on Eclipse alignments (Discussion #682)
Eclipse hasn't done much in formatting area that I'm aware of last few releases
I think there was stuff changed to support newer Java language constructs, like the updated switch statements and records types.
its probably best as a general rule to just release what we have once the main binaries are updated and if we get extra stuff great, but if not, that is ok too
That's my thinking, too. Is there a ticket for the existing issue for CSS? I'm not too concerned, as I only use this formatter for Java, anyway, but would be nice to link to it.
—
Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frevelc%2Fformatter-maven-plugin%2Fdiscussions%2F682%23discussioncomment-4615016&data=05%7C01%7C%7C98a53f10acd4473018c208daf017866a%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638086281075467921%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Kv77ZDAZ1b9d2f12uwsIS1ucaDE%2FhVntKMKrJlsGdAo%3D&reserved=0>, or unsubscribe<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAHODI73IYP7ZQZH4PUVY2LWRBTARANCNFSM6AAAAAATSPCDRI&data=05%7C01%7C%7C98a53f10acd4473018c208daf017866a%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638086281075467921%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=8jnOKrvYr6MMaVk8aMhOOTiPhUJp5eRxGj6KNvP1WZs%3D&reserved=0>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
|
I submitted fix for css issue. After that is in, think we are good to release for 2022-12 release. |
Beta Was this translation helpful? Give feedback.
-
|
I can release without #692 , but I tried to bump the xml-formatter to 0.3.0 after releasing that, and the XML formatting tests got NPEs. So, either something is broken in xml-formatter 0.3.0 or there's more work needed to migrate to it. I will release without that, and maybe we can get that working in the next release... perhaps a patch release if it's quick and easy. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
xml 0.3.0 applied now. |
Beta Was this translation helpful? Give feedback.
-
|
Is it worth doing a 2.22.1 or just wait until 2023-03 and include it in 2.23.0? |
Beta Was this translation helpful? Give feedback.
-
|
its fine to wait. |
Beta Was this translation helpful? Give feedback.
-
Eclipse hasn't done much in formatting area that I'm aware of last few releases but its probably ok to release the next cut. There is new logic for handling resources more easily that is opt in which is a good improvement here. Outside of outstanding work I'd love to get done, realistically I won't see myself using those updates probably until March. So rather than back up into release after release of Eclipse, its probably best as a general rule to just release what we have once the main binaries are updated and if we get extra stuff great, but if not, that is ok too.
Issues I'm aware of in the current releases is that CSS doesn't handle proper end of line (return) at end of files. Its not a big deal but may be more pronounced in case where 'resources' are now more easily used when opt in but probably not a show stopper to release this.
Beta Was this translation helpful? Give feedback.
All reactions