Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 'windows' users for contributions #847

Open
hazendaz opened this issue Mar 17, 2024 · 1 comment
Open

Support 'windows' users for contributions #847

hazendaz opened this issue Mar 17, 2024 · 1 comment
Labels

Comments

@hazendaz
Copy link
Member

When building, the pom.xml after recent updates keeps wanting to become LF not CRLF on windows. This needs fixed. I'm not clear what is causing it but 'git add .' restores it.

@hazendaz hazendaz added the bug label Mar 17, 2024
@ctubbsii
Copy link
Member

This is coming from the parent POM's sortpom plugin. The line ending is specified to be LF. It should be checked in as LF, and stay LF. It should never change to CRLF. I suggest Windows users use a text editor or an IDE that understands LF line endings, such as Notepad++ or Eclipse or IntelliJ, and not rely on tools that magically convert line endings via git checkin and checkout, because while those might work for git activity, it will be a problem when they try to run the code standardization tools (formatter, impsort, sortpom, etc.) which are run as part of the build.

One workaround, if users really don't want to do this is to simply build without the autoformat profile active, which I've made very convenient to do in the parent POM by using separate profiles (-P!autoformat or -Drevelc.skipFormat).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants