Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the Project #3

Open
XBloonyX opened this issue Dec 10, 2018 · 9 comments
Open

Improving the Project #3

XBloonyX opened this issue Dec 10, 2018 · 9 comments

Comments

@XBloonyX
Copy link
Contributor

XBloonyX commented Dec 10, 2018

As I've seen that there are interactions that do not work correctly and decided to improve some and also add some that have not before, and I can gladly donate for the "GoldenRex project" as long as they agree :)

I just want to keep the project alive and fresh, each time improving the project and finding small problems that can be fixed and I have found some small problems that I already fix ... and of course! I want to help in the project!

@XBloonyX XBloonyX changed the title interaction of sprites Improving the Project Dec 10, 2018
@rhelmot
Copy link
Owner

rhelmot commented Dec 10, 2018

If you have code changes you would like added to the project, you can use the github "pull request" feature (also a tab at the top of this page) to submit them to me and I'll happily evaluate them and merge them into the codebase. If you can't figure out how to do that, you can also just send me your files and I'll add the changes. I strongly suggest you learn to use git and github though, it's a valuable career skill :)

Regarding donations, I won't reject them but I can't guarantee I'll actually have the time to work on this! I'm a student and a researcher and I have many other projects I need to be keeping in the air for many different communities. Your interest is heartwarming, though!

@XBloonyX
Copy link
Contributor Author

apparently, I don't know how to use extraction request, but can I send lines of code here? if not in what other way can I?...

@rhelmot
Copy link
Owner

rhelmot commented Dec 10, 2018

What's your native language? i can find you a tutorial in that language.

@XBloonyX
Copy link
Contributor Author

XBloonyX commented Dec 10, 2018

español (spanish)

@rhelmot
Copy link
Owner

rhelmot commented Dec 10, 2018

http://aprendegit.com/que-es-un-pull-request/

You will need to be able to use git in order to do this. The tutorial uses a GUI for git, but I use the ordinary command line tool. You can use whatever you can find.

The bottom line is that you should push your changes to your fork (https://github.com/XBloonyX/smw-coop as opposed to https://github.com/rhelmot/smw-coop) and then submit the request that I pull the changes from your fork to mine. I will have the opportunity to give you specific feedback and request changes.

@rhelmot
Copy link
Owner

rhelmot commented Dec 10, 2018

(we can have conversations related to the specific pull request in the pull request's thread :)

@XBloonyX
Copy link
Contributor Author

hey, the sprites will not work properly without my miscroutines

@szechp
Copy link

szechp commented Jan 16, 2019

So did you guys actually merge all the changes with the latest commit? It just shows a commit by rhelmot, but xbloonyx's commits are not merged... Are the changes you guys made contained in the latest one?

@rhelmot
Copy link
Owner

rhelmot commented Jan 16, 2019

No - if you’re not familiar with how Github works, I need to merge that pull request and then the commits will be added to the master branch. I’ve requested that bloony make some changes and tell me more about the code before I merge it.

In the meantime, I’ve been working on the rideable platforms code specifically, and while it’s not perfect it definitely works for all the rotating and moving platforms I could think of, which is a huge improvement. Next I’ll be working on improving the item-carrying code with some extensive patches, but school has started again so my time is limited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants