Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request - Return objects as well, not just console text #1

Open
o-l-a-v opened this issue Aug 27, 2020 · 3 comments
Open

Feature request - Return objects as well, not just console text #1

o-l-a-v opened this issue Aug 27, 2020 · 3 comments
Assignees
@rhymeswithmogul
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
v2.0.0

Comments

@o-l-a-v
Copy link

o-l-a-v commented Aug 27, 2020

Would be great if this module also returned objects, so we can easily build upon it. Like, when testing SPF, if it could return "Enabled" equals $true or $false, and similar.
@rhymeswithmogul
Copy link
Owner

Good idea! I'll see what I can do.

rhymeswithmogul added a commit that referenced this issue Jun 1, 2023
@rhymeswithmogul
Add Bool OutputTypes to all cmdlets (issue #1)
c176fe4 
@o-l-a-v had a great idea.  Cmdlets ought to return $true if all checks
passed, and $false otherwise.  I've implemented this now.
@rhymeswithmogul
Copy link
Owner

Sorry for the embarrassingly-long delay on this one. I've got a lot going on, both on and off GitHub1

I'm starting to experiment with this idea in the return-objects branch. If it works well, I'll merge it into a future release.

@rhymeswithmogul rhymeswithmogul added this to the v1.2.0 milestone Jun 1, 2023
@rhymeswithmogul rhymeswithmogul added enhancement New feature or request good first issue Good for newcomers labels Jun 1, 2023
@rhymeswithmogul rhymeswithmogul self-assigned this Jun 1, 2023
@rhymeswithmogul rhymeswithmogul linked a pull request Jun 1, 2023 that will close this issue
Modify cmdlets to return true/false #4
Closed
@rhymeswithmogul rhymeswithmogul mentioned this issue Jun 1, 2023
Closed
@rhymeswithmogul rhymeswithmogul modified the milestones: v1.2.0, v2.0.0 Jan 19, 2024
@rhymeswithmogul
Copy link
Owner

This has been added in version v2.0.0 of the module. The cmdlets can now return true and false. I'm still thinking about a way to return a PSCustomObject while not breaking too much of the existing functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhymeswithmogul rhymeswithmogul

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

Modify cmdlets to return true/false rhymeswithmogul/Office365DnsChecker
2 participants
@o-l-a-v @rhymeswithmogul