Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all attributes for nodes and edges #399

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

randrescastaneda
Copy link

Dear @rich-iannone ,

I just added all the available attributes for nodes and edges of this page . Right now it is not possible to add edge attributes like arrowhead or minlen . However, with this small addition it is possible.

thanks.

@rich-iannone
Copy link
Owner

@randrescastaneda Thanks for the PR! Would you be able to fix the failing tests? Also node_aes() (https://github.com/rich-iannone/DiagrammeR/blob/master/R/node_aes.R) and edge_aes()(https://github.com/rich-iannone/DiagrammeR/blob/master/R/edge_aes.R) both need to be revised to accommodate the new parameters. Also, this vignette needs to be updated: https://github.com/rich-iannone/DiagrammeR/blob/master/vignettes/node-edge-data-frames.Rmd.

@randrescastaneda
Copy link
Author

Absolutely. It would be a pleasure.
I'll notify you when it is ready.
Best,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants