Allow loading more than one ELF binary #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping? |
billmcspadden-riscv
added
the
tgmm-agenda
There was a problem hiding this comment.
- The print_usage() function needs to be written so that it shows that multiple .elf files can be loaded. Perhaps: "Usage %s [options] <elf_file> [<elf_file> ...]"
- How was this tested? Is there a test we can add into the test directory that checks out this functionality?
- Does this adversely affect the processing of the RVFI arguments? I'm not quite sure how the RVFI options are to be used.
|
|
https://github.com/SRI-CSL/l3riscv hasn't been updated since 2019, it'll have no way of using riscv-software-src/riscv-isa-sim#390. Though to be honest the whole thing should probably be cut in favour of some other tandem verification approach; we have RVFI and we have the various official RISC-V testing frameworks. We don't need some ad-hoc one that's specifically for Sail-vs-Spike and nothing else. |
ptomsich
requested changes
Jul 25, 2023
This makes it possible for a follow-up commit to add logic that allows loading more than one ELF file (e.g. M-mode firmware and S-mode kernel).
arichardson
force-pushed
the
multiple-elf-files
branch
from
15eb701
to
a2c0389
Compare
|
I believe I've addressed all outstanding feedback. |
jrtc27
reviewed
Aug 3, 2023
arichardson
force-pushed
the
multiple-elf-files
branch
2 times, most recently
from
d4e1425
to
25ec35d
Compare
This makes it easier to use a separate M-mode bootloader and kernel payload (e.g. OpenSBI fw_jump). It also makes it easier to test booting systems such as FreeBSD without bundling the kernel with the bootloader.
arichardson
force-pushed
the
multiple-elf-files
branch
from
25ec35d
to
f6b8ef8
Compare
|
ping? |
|
monthly ping. |
|
This is absurd. This should have been merged months ago. |
billmcspadden-riscv
removed
the
tgmm-agenda
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to use a separate M-mode bootloader and kernel payload (e.g. OpenSBI fw_jump). It also makes it easier to test booting systems such as FreeBSD without bundling the kernel with the bootloader.