-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace crate prometheus with prometheus-client #13086
Comments
This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned. |
Would you mind elaborating what's the pain point? 🤔 |
This is a description before we have label guarded metrics. I tried to implement it in a clearer way, which required some tiny modifications to the upstream prometheus crate. But the crate was not in good maintain status. The PR was merged but no new version released (even till today). Thankfully, Yiming made an implementation without requiring modifications to the upstream. |
However, tikv/rust-prometheus is in a bad maintenance state, although there is not much to maintain. |
RisingWave initially chose the crate
prometheus
as the client for Prometheus because of its convenience. However, as the system became more complex, the flexibility of crateprometheus
brought a lot of burden to the maintenance of metrics.Besides,
prometheus
is not actively maintained now.tikv/rust-prometheus#490
Now, prometheus has its official rust client crate
prometheus-client
, which gives less flexibility but makes it easier to maintain. It's time to explore the official crate and replaceprometheus
withprometheus-client
.The text was updated successfully, but these errors were encountered: