Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mentoring: Keep or Remove? #66

Open
billdybas opened this issue Dec 21, 2017 · 3 comments
Open

Mentoring: Keep or Remove? #66

billdybas opened this issue Dec 21, 2017 · 3 comments
Labels

Comments

@billdybas
Copy link
Member

The node-api has some basic support for mentoring related things (headcounts, mentors, shifts, specialties); however, we don't currently use them, and our frontend doesn't use them (specifically commented out).

Is it still desired to have mentoring related endpoints in the node-api w/ some sort of frontend for them? (If so, I would like clarification on what we actually need, so we can modify/build the right thing)

Or, have we found suitable alternative tools, and should we remove the existing mentoring related features?

@vuzDylan @khanny17

@khanny17
Copy link

I'm fine with you removing these altogether. Things are fine with the two google forms that we use for mentoring.

@vuzDylan
Copy link
Contributor

It was for the much anticipated mentoring app that is currently blocked by all react calendars being literally awful

@billdybas
Copy link
Member Author

Since we don't currently use this functionality and have been doing fine without it for some time, I propose we remove all mentoring related things.

This reduces our overhead in maintaining / testing functionality that isn't being used.

If there is a need for the API to support mentoring again in the future, the new models / endpoints can be designed according to that future need, using the current code as inspiration. In addition, future mentoring features should only be included if the implemented features have tests (as the current mentoring features do not).

See: #70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants