chore(fe): fmt

[jog1t]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
rivet-inspector	Ready	Preview	Comment	Oct 26, 2025 11:29pm

2 Skipped Deployments

Project	Deployment	Preview	Comments	Updated (UTC)
rivet-cloud	Ignored			Oct 26, 2025 11:29pm
rivet-site	Ignored	Preview		Oct 26, 2025 11:29pm

[jog1t]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• chore(fe): fmt #3270 👈 (View in Graphite)
• fix(fe): redirect engine users to connect page when there's no actors #3269 : 1 other dependent PR (#3271 )
• fix(fe): empty token it is a valid token #3268
• main

---

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

PR Review: Frontend Formatting

Summary

This PR applies automated formatting changes to the frontend codebase using Biome. The changes are purely cosmetic and improve code consistency.

✅ Positive Observations

1. Consistent Import Ordering: All imports are now alphabetically sorted, which improves readability and reduces merge conflicts

   • Example: Icon, faBooks → faBooks, Icon

2. Biome Configuration Updated: The biome.json has been properly updated to:

   • Include **/*.tsx files in formatting scope
   • Adjust exclusions (changed !frontend to !frontend/packages and added !examples)
   • This is a good incremental approach to adopting formatting

3. Code Formatting Improvements:

   • Better line breaks for long parameter lists
   • Consistent multiline object/function formatting
   • Proper use of trailing commas

4. Type Improvements:

   • Changed @ts-ignore to @ts-expect-error in actor-inspector.tsx:25 - this is a best practice as it will error if the suppression becomes unnecessary

⚠️ Minor Concerns

1. Scope: This PR touches 96 files with 854 additions and 782 deletions. While this is expected for a formatting change, it makes the diff very large. Consider:

   • Ensure this doesn't conflict with other open PRs
   • Coordinate with team to merge this during a low-activity period

2. Missing Context: The PR body is empty. Consider adding:

   • Why this formatting is being applied now
   • Whether this is part of a larger effort to adopt Biome across the codebase
   • Instructions for developers to run formatting locally

3. Potential Issues:

   • In actor-metrics.tsx: The formatting changes are extensive but appear correct. However, ensure the metrics logic still works correctly after these changes
   • The change from !frontend to !frontend/packages in biome.json suggests only frontend/src will be formatted - verify this is intentional

🔍 Testing Recommendations

Since this is a formatting-only change, the main concerns are:

1. Visual Regression Testing: Ensure no unintended behavior changes in the UI
2. Build Verification: Confirm that pnpm build succeeds
3. Type Checking: Run TypeScript compiler to ensure no type errors
4. Linting: Verify no new linting errors were introduced

📝 Suggestions

1. PR Description: Add a brief description explaining this is an automated formatting change using Biome
2. Follow-up: Consider adding a pre-commit hook or CI check to enforce formatting on new code
3. Documentation: Update the CLAUDE.md or contributing guide to mention Biome formatting requirements

✅ Verdict

LGTM with minor suggestions - The changes are purely cosmetic and improve code consistency. The formatting rules appear sensible and follow TypeScript/React best practices. No security concerns, performance issues, or functional bugs detected.

The main recommendation is to:

• Add a PR description
• Coordinate merge timing to minimize conflicts
• Ensure CI passes before merging

[graphite-app]

Graphite Automations

"Test" took an action on this PR • (10/26/25)

1 assignee was added to this PR based on Kacper Wojciechowski's automation.

[pkg-pr-new]

More templates

• example-ai-agent
• example-background-jobs
• example-better-auth-external-db
• example-bots
• chat-room
• example-cloudflare-workers
• example-cloudflare-workers-hono
• example-counter
• example-counter-serverless
• example-crdt
• example-cursors
• example-cursors-raw-websocket
• example-database
• example-deno
• example-sqlite
• example-elysia
• example-express
• example-freestyle
• example-game
• example-hono
• example-hono-bun
• example-hono-react
• example-kitchen-sink
• example-next-js
• example-rate
• example-raw-fetch-handler
• example-raw-websocket-handler
• example-raw-websocket-handler-proxy
• example-react
• example-smoke-test
• starter
• example-stream
• example-sync
• example-tenant
• example-trpc
• example-workflows

@rivetkit/actor

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/actor@3270

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@3270

@rivetkit/core

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/core@3270

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/db@3270

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@3270

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@3270

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@3270

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@3270

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@3270

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@3270

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@3270

commit: 7a52cd7

[claude]

Code Review: chore(fe): fmt

Summary

This PR applies Biome formatting to the frontend codebase. The changes are primarily cosmetic, consisting of import statement reordering and code formatting improvements. Overall, this is a clean formatting pass with no functional changes detected.

---

✅ Positive Observations

1. Consistent formatting: The PR successfully applies consistent formatting across 94 files
2. Import ordering: Imports are now alphabetically sorted, which improves readability and reduces merge conflicts
3. No functional changes: After reviewing the diff, I confirmed there are no logic changes - only formatting improvements
4. Biome configuration improvements: The biome.json updates make sense:
   • Added **/*.tsx to the include list
   • Refined ignore patterns to be more specific (e.g., !frontend/packages instead of !frontend)
   • Added !**/*.gen.* to ignore generated files

---

💡 Observations & Minor Issues

1. Import Statement Ordering (Low Priority)

The imports are now alphabetically ordered, which is good. However, I noticed some inconsistencies in grouping patterns:

frontend/packages/components/src/actors/actor-config-tab.tsx:1

import { faBooks, Icon } from "@rivet-gg/icons";

The alphabetical ordering within destructured imports is good. This pattern is consistent throughout.

2. Code Comments Changed (Low Priority)

frontend/packages/components/src/actors/console/actor-inspector.tsx:25

- // @ts-ignore
+ // @ts-expect-error

This is actually an improvement! @ts-expect-error is preferred over @ts-ignore because it will error if the suppressed error is fixed, preventing stale comments.

3. Formatting in actor-metrics.tsx (Informational)

The file shows good formatting improvements:

• Better line breaks for complex ternary operators
• Improved readability in JSX expressions
• Consistent indentation

---

🔍 Potential Concerns

1. Large Surface Area (Medium Priority)

• Files changed: 94 files
• Lines changed: 839 additions, 768 deletions

While formatting changes are generally safe, the large number of files affected increases the risk of:

• Merge conflicts with other open PRs
• Git blame history being obscured for these lines

Recommendation: Ensure this is merged when there are minimal other frontend PRs in flight.

2. No Automated Tests Run (Medium Priority)

I don't see evidence in the PR description that tests were run after formatting.

Recommendation: Run the frontend test suite to confirm no regressions:

cd frontend
pnpm test
pnpm build

3. Biome Configuration Testing (Low Priority)

The ignore patterns in biome.json were changed. It would be good to verify that:

• Biome now correctly formats .tsx files that were previously ignored
• Generated files (**/*.gen.*) are properly excluded
• The !frontend/packages change doesn't accidentally include unwanted files

Recommendation: Run biome check to verify the new configuration works as expected.

---

🔒 Security Considerations

✅ No security concerns identified. This is purely a formatting change.

---

🎯 Performance Considerations

✅ No performance impact expected. Formatting changes don't affect runtime behavior.

---

🧪 Test Coverage

⚠️ Missing: No evidence of tests being run post-formatting.

Recommendation: Before merging, please confirm:

# Build the frontend to catch any TypeScript errors
pnpm build

# Run linting with the new Biome config
biome check

# If there's a test suite, run it
pnpm test

---

📝 Additional Recommendations

1. Documentation: Consider adding a note to the team about the new Biome formatting rules being enforced, especially the import ordering

2. Git Hooks: If not already in place, consider adding a pre-commit hook that runs Biome formatting automatically (though I see mention of lefthook in CLAUDE.md)

3. Follow-up: The CLAUDE.md file mentions:

   DO NOT RUN CARGO FMT AUTOMATICALLY (note for humans: we need to run cargo fmt when everything is merged together and make sure lefthook is working)

   Make sure the frontend formatting doesn't conflict with any planned Rust formatting work

---

✅ Final Verdict

LGTM with minor recommendations

This is a clean formatting pass that improves code consistency. My only recommendations are:

1. Run tests to confirm no regressions
2. Coordinate merge timing to minimize conflicts
3. Verify the updated Biome configuration works as expected

The code quality is good and there are no functional changes or bugs introduced.

---

Reviewed with attention to: Code quality, potential bugs, performance, security, test coverage, and adherence to CLAUDE.md guidelines