Skip to content

[Graphite MQ] Draft PR GROUP:spec_ec7bea (PRs 3531) #3532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Graphite MQ] Draft PR GROUP:spec_ec7bea (PRs 3531) #3532

wants to merge 1 commit into from

Conversation

@graphite-app
Copy link
Contributor

@graphite-app graphite-app bot commented Nov 23, 2025

This draft PR was created by the Graphite merge queue.
Trunk will be fast forwarded to the HEAD of this PR when CI passes, and the original PRs will be closed.

The following PRs are included in this draft PR:

@jog1t
fix(cloud): incorrect property names for railway (#3531)
6fe721d 
### TL;DR

Updated Rivet environment variable names by removing the `NEXT_PUBLIC_` prefix.

### What changed?

Modified the environment variable keys displayed in the Railway connection dialog:
- Changed `NEXT_PUBLIC_RIVET_RUNNER` to `RIVET_RUNNER`
- Changed `NEXT_PUBLIC_RIVET_TOKEN` to `RIVET_TOKEN`
- Changed `NEXT_PUBLIC_RIVET_ENDPOINT` to `RIVET_ENDPOINT`
- Changed `NEXT_PUBLIC_RIVET_NAMESPACE` to `RIVET_NAMESPACE`

### How to test?

1. Open the Railway connection dialog
2. Verify that the environment variable keys are displayed without the `NEXT_PUBLIC_` prefix
3. Ensure that the connection functionality still works correctly with the updated variable names

### Why make this change?

The `NEXT_PUBLIC_` prefix is typically used for client-side environment variables in Next.js applications. Since these Rivet variables are likely meant to be server-side only, removing this prefix ensures they won't be exposed to the client, improving security and following best practices for environment variable naming.
@vercel
Copy link

vercel bot commented Nov 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
rivet-inspector Ready Ready Preview Comment Nov 23, 2025 10:52pm
3 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
rivet-cloud Ignored Ignored Nov 23, 2025 10:52pm
rivet-site Ignored Ignored Preview Nov 23, 2025 10:52pm
rivetkit-serverless Skipped Skipped Nov 23, 2025 10:52pm

@vercel vercel bot temporarily deployed to Preview – rivetkit-serverless November 23, 2025 22:50 Inactive
@claude
Copy link

claude bot commented Nov 23, 2025

PR Review: fix(cloud): incorrect property names for railway

Summary

This PR removes the NEXT_PUBLIC_ prefix from environment variable names in the Railway connection dialog, changing them to RIVET_RUNNER, RIVET_TOKEN, RIVET_ENDPOINT, and RIVET_NAMESPACE.

✅ Looks Good

  1. Correct naming convention: The change aligns with the established naming convention used throughout the codebase. Looking at rivetkit-typescript/packages/rivetkit/src/client/config.ts, these are the expected environment variable names:

    • RIVET_ENDPOINT
    • RIVET_TOKEN
    • RIVET_NAMESPACE
    • RIVET_RUNNER

  2. Consistency: The change matches the naming in:

    • connect-manual-serverfull-frame.tsx (lines 301, 321, 342, 360)
    • Documentation at website/src/content/docs/connect/vm-and-bare-metal.mdx
    • The actual SDK client config that reads these variables

  3. Security improvement: The PR description correctly notes that NEXT_PUBLIC_ prefixed variables are client-exposed in Next.js. Since these contain sensitive data (especially the token), removing this prefix prevents accidental client-side exposure.

⚠️ Observation

The Vercel connection frame (connect-quick-vercel-frame.tsx) still uses NEXT_PUBLIC_ prefixed variables. However, this may be intentional since the Vercel template is specifically for Next.js applications that may need client-side access. Worth confirming if this is the intended behavior or if it should also be updated in a follow-up PR.

🧪 Testing Recommendations

  1. Open the Railway connection dialog and verify the env var keys display correctly
  2. Use the "Copy all raw" button to confirm the copied output has the correct variable names
  3. Test the Railway template deployment flow end-to-end if possible

Verdict

Approve - This is a straightforward and correct fix that brings the Railway dialog in line with the rest of the codebase.

🤖 Generated with Claude Code

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 23, 2025

More templates

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@3532

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/db@3532

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@3532

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@3532

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@3532

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@3532

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@3532

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@3532

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@3532

commit: 6fe721d

@graphite-app graphite-app bot closed this Nov 23, 2025
@graphite-app graphite-app bot deleted the gtmq_spec_ec7bea_1763938203943-aaddf650-226e-44b6-b797-451d495eba3a branch November 23, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jog1t