Skip to content

feat(pegboard): outbound runners #2873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 09-11-fix_engine_fe_remove_addresses
Choose a base branch
from
Open

feat(pegboard): outbound runners #2873

wants to merge 1 commit into from

Conversation

MasterPtato
Copy link
Contributor

No description provided.

@NathanFlurry NathanFlurry mentioned this pull request Sep 5, 2025
Closed
@vercel Vercel
Copy link

vercel bot commented Sep 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
rivet-cloud Error Error Sep 14, 2025 8:03pm
rivet-site Ready Ready Preview Comment Sep 14, 2025 8:03pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
rivet-studio Ignored Ignored Preview Sep 14, 2025 8:03pm

This was referenced Sep 5, 2025
Closed
Closed
Closed
@MasterPtato Graphite App
Copy link
Contributor Author

MasterPtato commented Sep 5, 2025 •
edited by NathanFlurry
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MasterPtato MasterPtato mentioned this pull request Sep 5, 2025
Closed
@claude Claude
Copy link

claude bot commented Sep 5, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 5, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/rivet-gg/engine/@rivetkit/engine-runner@2873

npm i https://pkg.pr.new/rivet-gg/engine/@rivetkit/engine-runner-protocol@2873

npm i https://pkg.pr.new/rivet-gg/engine/@rivetkit/engine-tunnel-protocol@2873

commit: e328b2d

@NathanFlurry NathanFlurry changed the base branch from 09-03-chore_runner_add_ability_to_disable_auto-shutdown to graphite-base/2873 September 5, 2025 21:39
@NathanFlurry NathanFlurry mentioned this pull request Sep 5, 2025
Closed
@MasterPtato MasterPtato force-pushed the 09-05-feat_pegboard_outbound_runners branch from 91aa71d to a6c2ba1 Compare September 6, 2025 01:20
@claude Claude
Copy link

claude bot commented Sep 6, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@MasterPtato MasterPtato changed the base branch from graphite-base/2873 to 09-03-chore_runner_add_ability_to_disable_auto-shutdown September 6, 2025 01:20
@MasterPtato MasterPtato marked this pull request as ready for review September 6, 2025 01:20
@MasterPtato MasterPtato force-pushed the 09-05-feat_pegboard_outbound_runners branch from a6c2ba1 to efb896e Compare September 6, 2025 01:24
@claude Claude
Copy link

claude bot commented Sep 6, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

graphite-app[bot]
graphite-app bot reviewed Sep 6, 2025
View reviewed changes
packages/services/pegboard/src/workflows/actor/runtime.rs
Comment on lines 328 to 333
let namespace_id = state.namespace_id;
let runner_id = state.runner_id;
let ns_runner_kind = &state.ns_runner_kind;

ctx.udb()?
.run(|tx, _mc| async move {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The destroy::clear_slot() function signature has been updated to include a ns_runner_kind parameter, but this call site is missing that parameter. The function should be called with ns_runner_kind as the fourth argument:

destroy::clear_slot(
    input.actor_id,
    namespace_id,
    runner_name_selector,
    runner_id,
    ns_runner_kind,  // This parameter is missing
    &tx,
)

Spotted by Diamond

Fix in Graphite

Is this helpful? React 👍 or 👎 to let us know.

@NathanFlurry NathanFlurry changed the base branch from 09-03-chore_runner_add_ability_to_disable_auto-shutdown to graphite-base/2873 September 6, 2025 21:11
This was referenced Sep 6, 2025
Closed
Open
NathanFlurry
NathanFlurry requested changes Sep 8, 2025
View reviewed changes
Copy link
Member

@NathanFlurry NathanFlurry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r

@MasterPtato MasterPtato force-pushed the 09-05-feat_pegboard_outbound_runners branch from efb896e to fc97845 Compare September 8, 2025 21:13
@MasterPtato MasterPtato changed the base branch from graphite-base/2873 to main September 8, 2025 21:13
@claude Claude
Copy link

claude bot commented Sep 11, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@claude Claude
Copy link

claude bot commented Sep 11, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

This was referenced Sep 11, 2025
Open
Open
@MasterPtato MasterPtato mentioned this pull request Sep 12, 2025
Open
@MasterPtato MasterPtato force-pushed the 09-05-feat_pegboard_outbound_runners branch from 236f452 to 57c4d39 Compare September 13, 2025 01:17
@MasterPtato MasterPtato force-pushed the 09-11-fix_engine_fe_remove_addresses branch from 4875469 to f3087f3 Compare September 13, 2025 01:17
@claude Claude
Copy link

claude bot commented Sep 13, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@claude Claude
Copy link

claude bot commented Sep 13, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

This was referenced Sep 13, 2025
Open
Open
@NathanFlurry NathanFlurry mentioned this pull request Sep 13, 2025
Open
This was referenced Sep 13, 2025
Open
Open
Open
Draft
Draft
Open
Draft
@NathanFlurry NathanFlurry force-pushed the 09-05-feat_pegboard_outbound_runners branch from 57c4d39 to e328b2d Compare September 14, 2025 20:00
@NathanFlurry NathanFlurry force-pushed the 09-11-fix_engine_fe_remove_addresses branch from f3087f3 to 78771e3 Compare September 14, 2025 20:00
@claude Claude
Copy link

claude bot commented Sep 14, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@claude Claude
Copy link

claude bot commented Sep 14, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@NathanFlurry NathanFlurry mentioned this pull request Sep 14, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@NathanFlurry NathanFlurry Awaiting requested review from NathanFlurry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MasterPtato @NathanFlurry