From f0643cc1e399dd3819091ba2bf682985bd017f32 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D9=85=D8=B5=D8=B7=D9=81=D9=8A=20=D9=85=D8=AD=D9=85=D9=88?= =?UTF-8?q?=D8=AF=20=D9=83=D9=85=D8=A7=D9=84=20=D8=A7=D9=84=D8=AF=D9=8A?= =?UTF-8?q?=D9=86?= <48567303+moste00@users.noreply.github.com> Date: Tue, 5 Mar 2024 02:28:02 +0200 Subject: [PATCH] sdb: remove unnecessary insertkeys parameter and dead code (#4328) --- librz/util/sdb/src/main.c | 21 +++------------------ 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/librz/util/sdb/src/main.c b/librz/util/sdb/src/main.c index 7cae8b31240..f486c873896 100644 --- a/librz/util/sdb/src/main.c +++ b/librz/util/sdb/src/main.c @@ -181,27 +181,12 @@ static int sdb_dump(const char *db, int fmt) { return sdb_grep_dump(db, fmt, false, NULL); } -static int insertkeys(Sdb *s, const char **args, int nargs, int mode) { +static int insertkeys(Sdb *s, const char **args, int nargs) { int must_save = 0; if (args && nargs > 0) { int i; for (i = 0; i < nargs; i++) { - switch (mode) { - case '-': - must_save |= sdb_query(s, args[i]); - break; - case '=': - if (strchr(args[i], '=')) { - char *v, *kv = (char *)strdup(args[i]); - v = strchr(kv, '='); - if (v) { - *v++ = 0; - sdb_disk_insert(s, kv, v); - } - free(kv); - } - break; - } + must_save |= sdb_query(s, args[i]); } } return must_save; @@ -415,7 +400,7 @@ int main(int argc, const char **argv) { sdb_config(s, options); int kvs = db0 + 2; if (kvs < argc) { - save |= insertkeys(s, argv + argi + 2, argc - kvs, '-'); + save |= insertkeys(s, argv + argi + 2, argc - kvs); } for (; (line = slurp(stdin, NULL));) { save |= sdb_query(s, line);