Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nomark filesystem command doesn't seem to work #499

Open
rjkroege opened this issue Jun 21, 2024 · 2 comments · Fixed by #500
Open

nomark filesystem command doesn't seem to work #499

rjkroege opened this issue Jun 21, 2024 · 2 comments · Fixed by #500

Comments

@rjkroege
Copy link
Owner

nomark written to a window's control file sets the nomark flag on the window. Empirically, that doesn't seem to actually do anything. I believe that I broke this in the refactoring of the undo / text buffers code.

@rjkroege
Copy link
Owner Author

I believe that the issue only occurs when setting the name of a window from the filesystem.

rjkroege added a commit that referenced this issue Jun 21, 2024
This change fixes #499: nomark works correctly when setting the name
of a buffer.
@rjkroege
Copy link
Owner Author

rjkroege commented Jul 8, 2024

Maybe not? The behaviour remains not working as expected. Perhaps bugs remain in the window tag handling code.

@rjkroege rjkroege reopened this Jul 8, 2024
rjkroege added a commit that referenced this issue Jul 9, 2024
When I refactored the undo code, I changed (perhaps wrongly) the
semantics of Undo marking. Adjust the filesystem interface to work
correctly despite this.

This is a better fix for #499.
rjkroege added a commit that referenced this issue Jul 9, 2024
When I refactored the undo code, I changed (perhaps wrongly) the
semantics of Undo marking. Adjust the filesystem interface to work
correctly despite this.

This is a better fix for #499.
rjkroege added a commit that referenced this issue Jul 9, 2024
When I refactored the undo code, I changed (perhaps wrongly) the
semantics of Undo marking. Adjust the filesystem interface to work
correctly despite this.

This is a better fix for #499.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant