Fix #4197 in various themes by showing empty option in SelectWidget when appropriate #4200

nickgros · 2024-05-24T19:48:50Z

Fix #4197 for antd, chakra-ui, fluentui-rc, material-ui, mui, semantic-ui

Checklist

I'm updating documentation
- I've checked the rendering of the Markdown text I've added
I'm adding or updating code
- I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
- I've updated docs if needed
- I've updated the changelog with a description of the PR
I'm adding a new feature
- I've updated the playground with an example use of the feature

packages/antd/src/widgets/SelectWidget/index.tsx

packages/fluentui-rc/src/SelectWidget/SelectWidget.tsx

packages/chakra-ui/src/SelectWidget/SelectWidget.tsx

packages/antd/test/__snapshots__/Form.test.tsx.snap

nickgros · 2024-05-28T15:06:41Z

@heath-freenome WDYT about moving this change to the optionsList util function so all themes are provided a placeholder entry when appropriate? This has a huge downstream effect on all of our tests (and maybe users selecting enums programmatically?) where the enum option index values would now be offset if a placeholder option is present. For example this would be the rendered HTML for a simple enum with ['foo', 'bar']

old

<select>
	<option value="">placeholder</option>
	<option value="0">foo</option>
	<option value="1">bar</option>
</select>

new

<select>
	<option value="0">placeholder</option>
	<option value="1">foo</option>
	<option value="2">bar</option>
</select>

CHANGELOG.md

heath-freenome · 2024-05-29T16:02:57Z

@heath-freenome WDYT about moving this change to the optionsList util function so all themes are provided a placeholder entry when appropriate? This has a huge downstream effect on all of our tests (and maybe users selecting enums programmatically?) where the enum option index values would now be offset if a placeholder option is present. For example this would be the rendered HTML for a simple enum with ['foo', 'bar']

old
<select>
	<option value="">placeholder</option>
	<option value="0">foo</option>
	<option value="1">bar</option>
</select>
new
<select>
	<option value="0">placeholder</option>
	<option value="1">foo</option>
	<option value="2">bar</option>
</select>

Hey Nick, That could be considered a breaking change. While it kind of make sense, it requires that we have access to placeholder in the fields (I'm not sure we do) in a way that would work properly. Maybe we can use the labelValue() function in place of the placeholder || ''? or we assign placeholder = '' in the destructure?

Vity01 · 2024-07-08T06:47:44Z

Any progress on this?

…, semantic-ui

…hemes

nickgros · 2024-07-08T12:28:14Z

Another reason to not update the optionsList utility is because it also affects radio groups. This best to be left to the SelectWidget implementations. Future PRs may improve the theme-specific behavior by e.g. rendering 'clear' buttons instead of a blank placeholder option.

heath-freenome

Just some tweaks to the CHANGELOG.md

heath-freenome · 2024-07-08T16:40:13Z

CHANGELOG.md

@@ -18,10 +18,34 @@ should change the heading of the (upcoming) version to include a major version b

 # 5.19.2


I've released 5.19.2 so you'll have to bump this

heath-freenome · 2024-07-08T16:40:33Z

CHANGELOG.md

@@ -92,6 +116,7 @@ should change the heading of the (upcoming) version to include a major version b
 - Fix case where NumberField would not properly reset the field when using programmatic form reset (#4202)[https://github.com/rjsf-team/react-jsonschema-form/issues/4202]
 - Updated widgets to handle undefined `target` in `onFocus` and `onBlur` handlers
 - Fix field disable or readonly property can't cover globalOptions corresponding property (#4212)[https://github.com/rjsf-team/react-jsonschema-form/pull/4212]
+- Added support for `default` values in `additionalProperties` in [#4199](https://github.com/rjsf-team/react-jsonschema-form/issues/4199), fixing [#3195](https://github.com/rjsf-team/react-jsonschema-form/issues/3915)


Where did this come from?

I think when I picked this up, we decided I would add this missing changelog message, assuming this would be a faster change to implement. I didn't realize it was missing until I revisited this.

CHANGELOG.md

Vity01 · 2024-07-08T18:33:46Z

Excellent, thank you @nickgros

mahendra790 · 2024-08-13T12:02:00Z

@nickgros Is there any way to opt out of this feature? because to remove this I need to add default: "" which makes it a valid field and required validation is not applied.

nickgros · 2024-08-13T12:19:15Z

@mahendra790 Sorry, I'm not understanding what you expect to happen, especially because this behavior was how the core theme worked originally.

Could you set the default value in the schema to be equal to the the first option in your list of options?

Co-authored-by: Heath C <[email protected]> Co-authored-by: Abdallah Al-Soqatri <[email protected]> Co-authored-by: Kevin Burnett <[email protected]> Co-authored-by: Marek Bodinger <[email protected]> Co-authored-by: Mehdi Salem <[email protected]> Co-authored-by: Nick Grosenbacher <[email protected]> Co-authored-by: Abdallah Al-Soqatri <[email protected]> Co-authored-by: Jonasz Wiącek <[email protected]> Co-authored-by: Bogdan Savluk <[email protected]> Co-authored-by: Christian Wendt <[email protected]> Co-authored-by: Ben Lambert <[email protected]> Co-authored-by: David R. Bild <[email protected]> Co-authored-by: Ariqun <[email protected]> Co-authored-by: Shivam Anand Murmu <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Shubham Biswas <[email protected]> Co-authored-by: popmanhe <[email protected]> Co-authored-by: Yuki Aoki <[email protected]> Co-authored-by: Xiangcheng Kuo <[email protected]> Co-authored-by: Bart van Andel <[email protected]> Co-authored-by: Laurent Direr <[email protected]> Co-authored-by: Vegard Stenvik <[email protected]> Co-authored-by: Appie <[email protected]> Co-authored-by: Oren Forer <[email protected]> Co-authored-by: Marcus Penn <[email protected]> Co-authored-by: joachimhagheim <[email protected]> Co-authored-by: MarekBodingerBA <[email protected]> Co-authored-by: momesana <[email protected]> Co-authored-by: Martti Roitto <[email protected]> Co-authored-by: Serge van den Oever <[email protected]> Co-authored-by: Enzo Ferey <[email protected]> Co-authored-by: Skyf0l <[email protected]> Co-authored-by: Jaejoon Han <[email protected]> Co-authored-by: とまとみ <[email protected]> Co-authored-by: Daniel Todd <[email protected]> Co-authored-by: Dmitry Dzhus <[email protected]> Co-authored-by: Alexander Kachkaev <[email protected]> Co-authored-by: shaddollxz <[email protected]> Co-authored-by: Changyu Geng <[email protected]> Co-authored-by: Helen Lin <[email protected]> Co-authored-by: solimant <[email protected]> Co-authored-by: David Li <[email protected]> fix(utils): direct lodash function import to improve bundling on library client side (#3976) fix: #3961 resolve all recurse list for object properties (#3981) fix gap in outline when label is hidden (#3984) Fix: Expose the internal `ajv` variable in the validator implementation classes (#3991) Fixes: #3972 indirectly by exposing the `ajv` variable for use in the issue Fix: Change FormHelperText usage with @mui/material to render divs (#4032) Fixes #4031 by switching the render component for `FormHelperText` to be `div` fix: Added support for anyOf/oneOf in uiSchema (#4055) Fixes #4039 by updating `MultiSchemaField` to properly support `anyOf`/`oneOf` arrays in the `uiSchema` Fix checkbox with 0 as a value was unselectable in antd (#4068) Fixed #4067 by properly dealing with enums that have 0 as a value Fix potential XSS in the preview button of FileWidget (#4065) Fix: Make 'ui:rows' option work with chakra-ui for textarea elements #4070 (#4078) Fix typo in ErrorsListTemplate example (#4087) Fix #4080 by moving `base64` encoder/decoder from `@rjsf/utils` to playground (#4093) Fix: Error state not resetting when schema changes (#4079) (#4103) Fix noImplicitAny error (#4106) Fixes: [WARNING] Duplicate key "include" in object literal [duplicate-object-key] (#4114) Fixes: Warning: validateDOMNesting(...): <p> cannot appear as a descendant of <p>. (#4117) Fix documentation to add missing Form imports (#4131) Fix #4127 to add missing `Form` import in documentation Fix: filename should be bold (#4125) Fix: use correct ConfigProvider context by using named imports (#4132) Fix 4134 by filtering out bad DOM props (#4140) Fixes: #4134 by updating the spreading of props onto the `TextField` to remove bad DOM fields Fixed Programmatic submit not working properly in Firefox (#4150) Fix Maximum call stack size exceeded in findSchemaDefinition (#4123) fix typos in constants.ts, Form.tsx (#4185) Fix mui imports in docs (#4218) fix] Resetting number fields should check the entire string when deciding to leave the input text alone (#4202) (#4220) Fixed performance issue with large schema dependencies and oneOf (#4203) (#4204) Fixed performance issue #4203 fix(core): field ui-options higher priority (#4212) fix(antd): disabled property of options of antd theme (#4216) fix: omitExtraData on submit and on validateForm (#4228) Fix IdSchema and PathSchema types (#4196) fixes #4236 Fix #4197 in various themes by showing empty option in SelectWidget when appropriate (#4200) fix: xss when rendering schema errors (#4256) fix 4215 and 4260 by updating optionsList() to take a uiSchema (#4263) Fixes #4215 and #4260 by supporting alternate titles for enums and anyOf/oneOf lists via the uiSchema Fixed Changelog (#4269)

nickgros requested a review from heath-freenome May 24, 2024 20:03

nickgros marked this pull request as draft May 24, 2024 20:03

nickgros commented May 24, 2024

View reviewed changes

packages/antd/src/widgets/SelectWidget/index.tsx Outdated Show resolved Hide resolved

heath-freenome reviewed May 24, 2024

View reviewed changes

packages/fluentui-rc/src/SelectWidget/SelectWidget.tsx Outdated Show resolved Hide resolved

heath-freenome reviewed May 24, 2024

View reviewed changes

packages/chakra-ui/src/SelectWidget/SelectWidget.tsx Outdated Show resolved Hide resolved

nickgros commented May 28, 2024

View reviewed changes

packages/antd/test/__snapshots__/Form.test.tsx.snap Outdated Show resolved Hide resolved

nickgros commented May 28, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

nickgros force-pushed the fix-4197 branch 2 times, most recently from f0bf135 to c936652 Compare May 28, 2024 15:15

nickgros added 3 commits July 8, 2024 06:52

fix rjsf-team#4197 for antd, chakra-ui, fluentui-rc, material-ui, mui…

a950092

…, semantic-ui

code review changes

89621ac

Clarify by creating showPlaceholderOption variable in all changed t…

6c4b39b

…hemes

nickgros force-pushed the fix-4197 branch from c936652 to 6c4b39b Compare July 8, 2024 11:31

nickgros added 2 commits July 8, 2024 07:32

Fix CHANGELOG

0bca1a4

Fix cases where placeholder option was accidentally given an index

ab2120a

nickgros marked this pull request as ready for review July 8, 2024 12:28

nickgros requested a review from heath-freenome July 8, 2024 12:28

heath-freenome approved these changes Jul 8, 2024

View reviewed changes

nickgros commented Jul 8, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

f06f227

nickgros merged commit b56da64 into rjsf-team:main Jul 8, 2024
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #4197 in various themes by showing empty option in SelectWidget when appropriate #4200

Fix #4197 in various themes by showing empty option in SelectWidget when appropriate #4200

nickgros commented May 24, 2024

nickgros commented May 28, 2024 •

edited

Loading

heath-freenome commented May 29, 2024 •

edited

Loading

Vity01 commented Jul 8, 2024

nickgros commented Jul 8, 2024

heath-freenome left a comment

heath-freenome Jul 8, 2024

heath-freenome Jul 8, 2024

nickgros Jul 8, 2024

Vity01 commented Jul 8, 2024

mahendra790 commented Aug 13, 2024

nickgros commented Aug 13, 2024

		@@ -18,10 +18,34 @@ should change the heading of the (upcoming) version to include a major version b

		# 5.19.2

Fix #4197 in various themes by showing empty option in SelectWidget when appropriate #4200

Fix #4197 in various themes by showing empty option in SelectWidget when appropriate #4200

Conversation

nickgros commented May 24, 2024

Checklist

nickgros commented May 28, 2024 • edited Loading

heath-freenome commented May 29, 2024 • edited Loading

Vity01 commented Jul 8, 2024

nickgros commented Jul 8, 2024

heath-freenome left a comment

Choose a reason for hiding this comment

heath-freenome Jul 8, 2024

Choose a reason for hiding this comment

heath-freenome Jul 8, 2024

Choose a reason for hiding this comment

nickgros Jul 8, 2024

Choose a reason for hiding this comment

Vity01 commented Jul 8, 2024

mahendra790 commented Aug 13, 2024

nickgros commented Aug 13, 2024

nickgros commented May 28, 2024 •

edited

Loading

heath-freenome commented May 29, 2024 •

edited

Loading