Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External plugin templates #18

Open
rktjmp opened this issue Mar 7, 2021 · 7 comments
Open

External plugin templates #18

rktjmp opened this issue Mar 7, 2021 · 7 comments

Comments

@rktjmp
Copy link
Owner

rktjmp commented Mar 7, 2021

https://gist.github.com/kunzaatko/65c2317018afdbfc69abac9c7737722b

@rktjmp
Copy link
Owner Author

rktjmp commented Mar 7, 2021

I do not think these files belong in the core lush project because:

  1. They'll actually end up pretty hidden away for people who want to find them ("just cp .local/nvim/site/packer/compiled/lush.nvim/... ..." bleh)

  2. They might end up with frequent changes or "upstream plugin changed" patches which will clutter lush's mainline git log.

I think they either go into:

I don't think I mind hosting a starter/helper repo, probably mostly just a matter of deciding on a format and writing a readme on what they are and how to use them.

@kunzaatko

@kunzaatko
Copy link
Contributor

Maybe they could be added as a submodule to the https://github.com/rktjmp/lush-template.

@rktjmp
Copy link
Owner Author

rktjmp commented Mar 7, 2021

Isn't that just including them directly but with extra steps?

At any rate. I think they should by default be:

  • one rule per line
  • commented out

So someone can grab the file and just update whatever parts they need without clearing any existing highlight links setup by the plugins.

How/where are you generating these from?

@kunzaatko
Copy link
Contributor

kunzaatko commented Mar 8, 2021

Isn't that just including them directly but with extra steps?

I think that i order to download the submodules, you have to have write git submodule update to fetch them. That makes it opt-in rather then opt-out...

  • one rule per line
  • commented out

Sure, that is sensible.

How/where are you generating these from?

I just grabbed some big colourschemes, concatenated them, sorted them, filtered them and then edited the result with some vim macros. This inherently means, that the list of groups is not necessarily exhaustive...

I will make a private repo and invite you. Then, when it gets stable and we figure out the specific layout, we can make it public and figure out where to put it (or if I should transfer ownership to you or something)...

@kunzaatko
Copy link
Contributor

kunzaatko commented Mar 8, 2021

You can look at the new repo I created. It should work with the new extends/with API hopefully. @rktjmp

@rktjmp
Copy link
Owner Author

rktjmp commented Mar 9, 2021

Just thinking out loud,

the starter template could actually have multiple branches by default

  • main/master/slim/default -> whats there now
  • light_dark -> light dark variant template
  • plugins -> has the plugins

You could probably start main then just merge in what you want git merge light_dark git merge plugins.

What I want to avoid is someone cloning down that repo, seeing 1000 files and thinking Lush is really heavy and complex when it really isn't.

@kunzaatko
Copy link
Contributor

That seems reasonable. I think that it should also be emphasized in the README that the plugins are really templates and there is no need to implement a lot of them... So the template should then be in one repo not two as we agreed upon before...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants