-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
Get changes from development branch
@Ilnicki010 thanks for taking this task. I made a couple small changes (adding hot reload so it's easier to tweak the component without a page refresh and enforced some stylelint rules). I think there a two main things to try and solve here:
Let me know if you'd like to give this one another go or I can take it otherwise. Thanks! |
And that seems to work, see this fiddle: https://jsfiddle.net/rlueder/982oegbz/23/ :) |
The flow of the Select component works for most screen sizes, as the window is resized it might still fall off screen but I think that's an edge case: The position of the menu is now correct, it took quite some overwrites with There is one main issue left before closing/merging this PR:
|
I actually just found another issue, the
|
…intro (1st commit from a moving car :P) I'm not driving btw...
I made progress, a few things remaining I want to finish today still:
https://developer.mozilla.org/en-US/docs/Web/API/Intersection_Observer_API |
No description provided.