Static validation error helper dead code?

[ravangen]

While reviewing some error handling code, I came across some code that appears unused. Perhaps I am missing something?

graphql-ruby/lib/graphql/static_validation/error.rb

Lines 6 to 14 in f72c7a1

	# Convenience for validators
	module ErrorHelper
	# Error `error_message` is located at `node`
	def error(error_message, nodes, context: nil, path: nil, extensions: {})
	path ||= context.path
	nodes = Array(nodes)
	GraphQL::StaticValidation::Error.new(error_message, nodes: nodes, path: path)
	end
	end

[rmosolgo]

I think you're right, it looks like this one is used instead:

graphql-ruby/lib/graphql/static_validation/base_visitor.rb

Line 190 in f72c7a1

def add_error(error, path: nil)

D'oh, but I just checked GraphQL-Pro, it's still using this as part of the OperationStore feature. I'm game to migrate that code to use add_error instead, then we could remove this "helper."